Skip to content

drm/{amdgpu,nouveau}: Remove old fbdev hooks

Thomas Zimmermann amd-gfx dri-devel nouveau 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 19 repliesIn review
  2. v18 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- call vga_switcheroo_process_delayed_switch() from drm_lastclose() (Sima)
- documentation updates

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9drm: Do delayed switcheroo in drm_lastclose()drivers/gpu/drm/drm_file.c drivers/gpu/vga/vga_switcheroo.c+5 -28 replies
2/9drm/amdgpu: Do not set struct drm_driver.lastclosedrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c+0 -203 replies
3/9drm/nouveau: Do not set struct drm_driver.lastclosedrivers/gpu/drm/nouveau/nouveau_drm.c drivers/gpu/drm/nouveau/nouveau_vga.c drivers/gpu/drm/nouveau/nouveau_vga.h+0 -92 replies
4/9drm/nouveau: Do not set struct drm_mode_config_funcs.output_poll_changeddrivers/gpu/drm/nouveau/dispnv50/disp.c drivers/gpu/drm/nouveau/nouveau_display.c+0 -21 reply
5/9drm/nouveau: Implement switcheroo reprobe with drm_client_dev_hotplug()drivers/gpu/drm/nouveau/nouveau_vga.c+2 -13 replies
6/9drm/fbdev-helper: Update documentation on obsolete callbacksdrivers/gpu/drm/drm_fb_helper.c+7 -151 reply
7/9drm/fbdev-helper: Remove drm_fb_helper_output_poll_changed()drivers/gpu/drm/drm_fb_helper.c include/drm/drm_fb_helper.h+0 -211 reply
8/9drm: Remove struct drm_driver.lastclosedrivers/gpu/drm/drm_file.c drivers/gpu/drm/drm_internal.h include/drm/drm_drv.h+6 -510 replies
9/9drm: Remove struct drm_mode_config_funcs.output_poll_changeddrivers/gpu/drm/drm_probe_helper.c include/drm/drm_mode_config.h+1 -250 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchDaniel VetterDanilo KrummrichAlex Deucher
1/9R-b R-b
2/9R-b R-b
3/9R-b A-b
4/9R-b A-b
5/9R-b A-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/9] drm/{amdgpu,nouveau}: Remove old fbdev hooks

After switching all drivers' fbdev emulation to DRM client, the old fbdev hooks are now obsolete. Only amgdpu and nouveau still use them in a several places. Remove the hooks from the drivers and the DRM core.

The series would ideally be merged at once via drm-misc-next.

v2:
- call vga_switcheroo_process_delayed_switch() from drm_lastclose() (Sima)
- documentation updates

Thomas Zimmermann (9):
drm: Do delayed switcheroo in drm_lastclose() drm/amdgpu: Do not set struct drm_driver.lastclose drm/nouveau: Do not set struct drm_driver.lastclose drm/nouveau: Do not set struct
drm_mode_config_funcs.output_poll_changed
drm/nouveau: Implement switcheroo reprobe with
drm_client_dev_hotplug()
drm/fbdev-helper: Update documentation on obsolete callbacks drm/fbdev-helper: Remove drm_fb_helper_output_poll_changed()
drm: Remove struct drm_driver.lastclose
drm: Remove struct drm_mode_config_funcs.output_poll_changed

 drivers/gpu/drm/amd/amdgpu/amdgpu.h       |  1 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c   |  2 --
 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c   | 17 -----------
 drivers/gpu/drm/drm_fb_helper.c           | 37 +++++------------------
 drivers/gpu/drm/drm_file.c                | 32 ++++++--------------
 drivers/gpu/drm/drm_internal.h            |  1 -
 drivers/gpu/drm/drm_probe_helper.c        | 10 +-----
 drivers/gpu/drm/nouveau/dispnv50/disp.c   |  1 -
 drivers/gpu/drm/nouveau/nouveau_display.c |  1 -
 drivers/gpu/drm/nouveau/nouveau_drm.c     |  1 -
 drivers/gpu/drm/nouveau/nouveau_vga.c     | 10 ++----
 drivers/gpu/drm/nouveau/nouveau_vga.h     |  1 -
 drivers/gpu/vga/vga_switcheroo.c          |  3 +-
 include/drm/drm_drv.h                     | 28 -----------------
 include/drm/drm_fb_helper.h               |  6 ----
 include/drm/drm_mode_config.h             | 16 ----------
 16 files changed, 21 insertions(+), 146 deletions(-)
Signature · 1 line
2.46.0