i2c: npcm: read/write operation, checkpatch
Status from this message: merged to i2c/i2c-host.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest4 patches 2 repliesApplied
- v74 patches 15 repliesSuperseded
- v64 patches 6 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 6 patches | 12 replies | Applied | |
| v4 | 6 patches | 11 replies | Superseded | |
| v3 | 6 patches | 10 replies | Superseded | |
| v2 | 7 patches | 32 replies | Superseded | |
| v1 | 7 patches | 3 replies | Superseded |
Patches in v8 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | i2c: npcm: Modify timeout evaluation mechanismdrivers/ | +15 | 0 replies | |
| 2/4 | i2c: npcm: Assign client address earlier for `i2c_recover_bus()`drivers/ | +17 | 0 replies | |
| 3/4 | i2c: npcm: use i2c frequency tabledrivers/ | +288 | 0 replies | |
| 4/4 | i2c: npcm: Enable slave in eob interruptdrivers/ | +6 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Tali Perry |
|---|---|
| 1/4 | R-b |
| 2/4 | R-b |
| 3/4 | R-b |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v8 0/4] i2c: npcm: read/write operation, checkpatch
This patchset includes the following fixes:
- Enable the target functionality in the interrupt handling routine when the i2c transfer is about to finish.
- Correct the read/write operation procedure.
- Introduce a software flag to handle the bus error (BER) condition which is not caused by the i2c transfer.
- Modify timeout calculation.
- Assign the client address earlier logically.
- Use an i2c frequency table for the frequency parameters assignment.
- Coding style fix.
The NPCM I2C driver is tested on NPCM750 and NPCM845 evaluation boards.
Addressed comments from:
- Paul Menzel : https://lore.kernel.org/lkml/67d34216-e98b-43d9-afd1-
[email protected]/
- Andi Shyti : https://lore.kernel.org/lkml/cexpymszobfl7676acibp474e
q3qx242ppo22wrbjepxhufkvt@w4ptnmfjx7yo/
- Tali Perry : https://lore.kernel.org/lkml/CAHb3i=uT+Zx8m4hAF1M2yjCn
[email protected]/
Changes since version 7:
- Modify the commit title for better description.
- Modify i2c address assignment.
Changes since version 6:
- Modify code comments.
- Remove redundant code check.
- Remove i2c address mask.
Changes since version 5:
- Correct "EAGAIN" to "-EAGAIN" in the commit message.
- Configure the bus->dest_addr by calling i2c_8bit_addr_from_msg() and remove the I2C_M_RD flag when calling i2c_recover_bus().
- Fix the commit message which meets a too small wrapping limit.
Changes since version 4:
- Add more description for the codes.
- Modify the term "function" to "function()" in the commit message and code comments.
Changes since version 3:
- Remove "Bug fixes" in the cover letter title.
- Modify the term "function" to "func()" in the commit message and code comments.
- Correct the coding style.
Changes since version 2:
- Add more explanations in the commit message and code modification.
- Use lower character names for declarations.
- Remove Fixes tags in commits which are not to fix bugs.
Changes since version 1:
- Restore the npcm_i2caddr array length to fix the smatch warning.
- Remove unused variables.
- Handle the condition where scl_table_cnt reaches to the maximum value.
- Fix the checkpatch warning.
Charles Boyer (1):
i2c: npcm: Enable slave in eob interrupt
Tyrone Ting (3):
i2c: npcm: Modify timeout evaluation mechanism
i2c: npcm: Assign client address earlier for i2c_recover_bus()
i2c: npcm: use i2c frequency table
drivers/i2c/busses/i2c-npcm7xx.c | 427 +++++++++++++++++++++++-------- 1 file changed, 326 insertions(+), 101 deletions(-)
base-commit: 663bff1ddfe4ecbba3bcf4a74646bb388b1ad5b2
Signature · 1 line
2.34.1