Skip to content

Allow partial memory mapping for cpu memory

Andi Shyti dri-devel intel-gfx 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/22 patches 5 repliesIn review
  2. v2 posting 1/20 of 2 patches 0 repliesSuperseded
  3. v12 patches 14 repliesSuperseded

Changes in v2 from the cover letter

- Added Nirmoy's tags.

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/i915/gem: Do not look for the exact address in nodedrivers/gpu/drm/i915/gem/i915_gem_mman.c+3 -30 replies
1/2drm/i915/gem: Do not look for the exact address in nodedrivers/gpu/drm/i915/gem/i915_gem_mman.c+3 -30 replies
2/2drm/i915/gem: Calculate object page offset for partial memory mappingdrivers/gpu/drm/i915/gem/i915_gem_mman.c drivers/gpu/drm/i915/i915_mm.c drivers/gpu/drm/i915/i915_mm.h+16 -30 replies
2/2drm/i915/gem: Calculate object page offset for partial memory mappingdrivers/gpu/drm/i915/gem/i915_gem_mman.c drivers/gpu/drm/i915/i915_mm.c drivers/gpu/drm/i915/i915_mm.h+16 -30 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchNirmoy Das
1/2R-b R-b
1/2R-b R-b
2/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] Allow partial memory mapping for cpu memory

Hi,

I am resending this patch series, not to disregard the previous discussions, but to ensure it gets tested with the IGTs that Krzysztof has provided.

This patch series finalizes the memory mapping fixes and improvements by enabling partial memory mapping for CPU memory as well.

The concept of partial memory mapping, achieved by adding an object offset, was implicitly introduced in commit 8bdd9ef7e9b1 ("drm/i915/gem: Fix Virtual Memory mapping boundaries calculation") for GTT memory.

To address a previous discussion with Sima and Matt, this feature is used by Mesa and is required across all platforms utilizing Mesa. Although Nirmoy suggested using the Fixes tag to backport this to previous kernels, I view this as a new feature rather than a fix.

Lionel, please let me know if you have a different perspective and believe this should be treated as a bug fix, requiring it to be backported to stable kernels.

The IGTs have been developed in collaboration with the Mesa team to replicate the exact Mesa use case[*].

Thanks Chris for the support, thanks Krzysztof for taking care of the IGT tests, thanks Nirmoy for your reviews and thanks Sima and Matt for the discussion on this series.

Andi

[*] https://patchwork.freedesktop.org/patch/608232/?series=137303&rev=1

Test-with: [email protected]

Changelog:
==========
v1 -> v2
- Added Nirmoy's tags.

Andi Shyti (2):
drm/i915/gem: Do not look for the exact address in node drm/i915/gem: Calculate object page offset for partial memory mapping

 drivers/gpu/drm/i915/gem/i915_gem_mman.c | 10 ++++++----
 drivers/gpu/drm/i915/i915_mm.c           | 12 +++++++++++-
 drivers/gpu/drm/i915/i915_mm.h           |  3 ++-
 3 files changed, 19 insertions(+), 6 deletions(-)
Signature · 1 line
2.45.2