Skip to content

tracefs: inode alloc/free related fixes

Mathias Krause linux-trace-kernel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tracefs: Fix inode allocationfs/tracefs/inode.c+1 -10 replies
2/2tracefs: Don't overlay 'struct inode'fs/tracefs/internal.h+2 -46 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] tracefs: inode alloc/free related fixes

Hi Steven,

We ran into yet another tracefs related bug but, fortunately, were able to root cause it ourselves.

The problem only occurs when CONFIG_RANDSTRUCT is enabled and one gets (un)lucky to hit a random seed that'll overlay the 'rcu' member of the union with a list_head in 'vfs_inode' -- quite unlikely but, apparently, we're exceptional "lucky" with our testing ;)

The first patch is more of an API correctness fix, to bring the tracefs inode cache in line with all the other filesystems. The second patch actually fixes the bug, which, I think, may also be the cause for what Ilkka is seeing[1].

Please apply!

Thanks,
Mathias

[1] https://lore.kernel.org/all/CAE4VaREzY+a2PvQJYJbfh8DwB4OP7kucZG-e28H22xyWob1w_A@mail.gmail.com/

Mathias Krause (2):
tracefs: Fix inode allocation
tracefs: Don't overlay 'struct inode'

 fs/tracefs/inode.c    | 2 +-
 fs/tracefs/internal.h | 6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)
Signature · 1 line
2.43.0