Skip to content

ALSA: Drop legacy snd_print*()

Takashi Iwai linux-sound 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest54 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/54ALSA: portman2x4: Use standard print APIsound/drivers/portman2x4.c+9 -100 replies
2/54ALSA: mts64: Use standard print APIsound/drivers/mts64.c+9 -90 replies
3/54ALSA: mpu401: Use standard print APIsound/drivers/mpu401/mpu401.c+8 -80 replies
4/54ALSA: mpu401_uart: Use standard print APIsound/drivers/mpu401/mpu401_uart.c+17 -140 replies
5/54ALSA: mtpav: Use standard print APIsound/drivers/mtpav.c+5 -90 replies
6/54ALSA: opl3: Use standard print APIsound/drivers/opl3/opl3_lib.c sound/drivers/opl3/opl3_midi.c sound/drivers/opl3/opl3_oss.c +1 more+56 -730 replies
7/54ALSA: opl4: Use standard print APIsound/drivers/opl4/opl4_lib.c sound/drivers/opl4/yrw801.c+5 -50 replies
8/54ALSA: serial-u16550: Use standard print APIsound/drivers/serial-u16550.c+21 -200 replies
9/54ALSA: virmidi: Use standard print APIsound/drivers/virmidi.c+4 -40 replies
10/54ALSA: vx_core: Drop unused dev fieldinclude/sound/vx_core.h sound/drivers/vx/vx_hwdep.c+1 -20 replies
11/54ALSA: vx_core: Use standard print APIsound/drivers/vx/vx_core.c sound/drivers/vx/vx_hwdep.c sound/drivers/vx/vx_pcm.c +1 more+44 -480 replies
12/54ALSA: aloop: Use standard print APIsound/drivers/aloop.c+1 -10 replies
13/54ALSA: dummy: Use standard print APIsound/drivers/dummy.c+2 -30 replies
14/54ALSA: pcsp: Use standard print APIsound/drivers/pcsp/pcsp.c sound/drivers/pcsp/pcsp_lib.c sound/drivers/pcsp/pcsp_mixer.c+31 -300 replies
15/54ALSA: i2c: cs8427: Use standard print APIsound/i2c/cs8427.c+20 -170 replies
16/54ALSA: i2c: pt2258: Use standard print APIsound/i2c/other/pt2258.c+3 -30 replies
17/54ALSA: i2c: Drop commented old debug printssound/i2c/other/ak4113.c sound/i2c/other/ak4114.c sound/i2c/other/ak4117.c +2 more+0 -320 replies
18/54ALSA: ad1816a: Use standard print APIsound/isa/ad1816a/ad1816a.c sound/isa/ad1816a/ad1816a_lib.c+16 -160 replies
19/54ALSA: als100: Use standard print APIsound/isa/als100.c+7 -90 replies
20/54ALSA: azt2320: Use standard print APIsound/isa/azt2320.c+6 -80 replies
21/54ALSA: cmi8328: Use standard print APIsound/isa/cmi8328.c+21 -210 replies
22/54ALSA: cmi8330: Use standard print APIsound/isa/cmi8330.c+17 -190 replies
23/54ALSA: cs4236: Use standard print APIsound/isa/cs423x/cs4236.c sound/isa/cs423x/cs4236_lib.c+45 -420 replies
24/54ALSA: es1688: Use standard print APIinclude/sound/es1688.h sound/isa/es1688/es1688.c sound/isa/es1688/es1688_lib.c+31 -270 replies
25/54ALSA: es18xx: Use standard print APIsound/isa/es18xx.c+46 -410 replies
26/54ALSA: gus: Use standard print APIsound/isa/gus/gus_dma.c sound/isa/gus/gus_io.c sound/isa/gus/gus_irq.c +10 more+266 -1780 replies
27/54ALSA: msnd: Use standard print APIsound/isa/msnd/msnd.c sound/isa/msnd/msnd_midi.c sound/isa/msnd/msnd_pinnacle.c+112 -1221 reply
28/54ALSA: opl3sa2: Use standard print APIsound/isa/opl3sa2.c+22 -240 replies
29/54ALSA: opti9xx: Use standard print APIinclude/sound/aci.h sound/isa/opti9xx/miro.c sound/isa/opti9xx/opti92x-ad1848.c+119 -1070 replies
30/54ALSA: sb: Use standard print APIsound/isa/sb/emu8000.c sound/isa/sb/emu8000_patch.c sound/isa/sb/emu8000_synth.c +7 more+105 -940 replies
31/54ALSA: control_led: Use dev_err()sound/core/control_led.c+1 -10 replies
32/54ALSA: pcm: oss: Use pr_debug()sound/core/oss/pcm_plugin.h+1 -10 replies
33/54ALSA: sc6000: Use standard print APIsound/isa/sc6000.c+90 -870 replies
34/54ALSA: sscape: Use standard print APIsound/isa/sscape.c+48 -480 replies
35/54ALSA: wavefront: Use standard print APIinclude/sound/snd_wavefront.h sound/isa/wavefront/wavefront.c sound/isa/wavefront/wavefront_fx.c +2 more+158 -1540 replies
36/54ALSA: wss: Use standard print APIsound/isa/wss/wss_lib.c+90 -880 replies
37/54ALSA: riptide: Use standard print APIsound/pci/riptide/riptide.c+98 -950 replies
38/54ALSA: korg1212: Use standard print APIsound/pci/korg1212/korg1212.c+16 -140 replies
39/54ALSA: lx6464es: Cleanup the print API usagessound/pci/lx6464es/lx_core.c sound/pci/lx6464es/lx_core.h+4 -70 replies
40/54ALSA: azt3328: Use pr_warn()sound/pci/azt3328.c+1 -10 replies
41/54ALSA: emu10k1: Use dev_warn()sound/pci/emu10k1/emu10k1_patch.c+3 -20 replies
42/54ALSA: trident: Use standard print APIsound/pci/trident/trident_memory.c+5 -50 replies
43/54ALSA: emux: Use standard print APIinclude/sound/soundfont.h sound/synth/emux/emux_hwdep.c sound/synth/emux/emux_oss.c +3 more+63 -520 replies
44/54ALSA: usx2y: Use standard print APIsound/usb/usx2y/us122l.c sound/usb/usx2y/usX2Yhwdep.c sound/usb/usx2y/usb_stream.c +4 more+141 -1500 replies
45/54ALSA: usb-audio: Use standard print APIsound/usb/midi.c+3 -30 replies
46/54ALSA: intel8x0: Drop unused snd_printd() callssound/pci/intel8x0.c sound/pci/intel8x0m.c+0 -60 replies
47/54ALSA: vxpocket: Use standard print APIsound/pcmcia/vx/vxp_ops.c sound/pcmcia/vx/vxpocket.c+14 -210 replies
48/54ALSA: pdaudiocf: Use standard print APIsound/pcmcia/pdaudiocf/pdaudiocf.c sound/pcmcia/pdaudiocf/pdaudiocf_core.c sound/pcmcia/pdaudiocf/pdaudiocf_irq.c+24 -360 replies
49/54ALSA: ppc: Use standard print APIsound/ppc/awacs.c sound/ppc/daca.c sound/ppc/keywest.c +3 more+41 -450 replies
50/54ALSA: sh: Use standard print APIsound/sh/aica.c sound/sh/sh_dac_audio.c+7 -80 replies
51/54ALSA: sparc: Use standard print APIsound/sparc/amd7930.c sound/sparc/cs4231.c+49 -370 replies
52/54ALSA: asihpi: Use standard print APIsound/pci/asihpi/asihpi.c sound/pci/asihpi/hpioctl.c+44 -590 replies
53/54ALSA: docs: Drop snd_print*() stuffDocumentation/sound/hd-audio/notes.rst Documentation/sound/kernel-api/writing-an-alsa-driver.rst+0 -310 replies
54/54ALSA: core: Drop snd_print stuff and coinclude/sound/core.h sound/core/Kconfig sound/core/misc.c+0 -1470 replies

Reviews trailers per patch

1 of 54 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJaroslav Kysela
SeriesR-b
1/54
2/54
3/54
4/54
5/54
6/54
7/54
8/54
9/54
10/54
11/54
12/54
13/54
14/54
15/54
16/54
17/54
18/54
19/54
20/54
21/54
22/54
23/54
24/54
25/54
26/54
27/54R-b
28/54
29/54
30/54
31/54
32/54
33/54
34/54
35/54
36/54
37/54
38/54
39/54
40/54
41/54
42/54
43/54
44/54
45/54
46/54
47/54
48/54
49/54
50/54
51/54
52/54
53/54
54/54

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/54] ALSA: Drop legacy snd_print*()

Hi,

this is a bit largish clean up patch series for dropping the legacy snd_printd() and co. Almost only the old drivers are still using those API functions, and it's time to change them to the modern ones like dev_err() and dev_dbg().

This ended up with the drop of a Kconfig item
CONFIG_SND_VERBOSE_PRINTK, too.

Takashi

===

Takashi Iwai (54):
ALSA: portman2x4: Use standard print API
ALSA: mts64: Use standard print API
ALSA: mpu401: Use standard print API
ALSA: mpu401_uart: Use standard print API
ALSA: mtpav: Use standard print API
ALSA: opl3: Use standard print API
ALSA: opl4: Use standard print API
ALSA: serial-u16550: Use standard print API
ALSA: virmidi: Use standard print API
ALSA: vx_core: Drop unused dev field
ALSA: vx_core: Use standard print API
ALSA: aloop: Use standard print API
ALSA: dummy: Use standard print API
ALSA: pcsp: Use standard print API
ALSA: i2c: cs8427: Use standard print API
ALSA: i2c: pt2258: Use standard print API
ALSA: i2c: Drop commented old debug prints
ALSA: ad1816a: Use standard print API
ALSA: als100: Use standard print API
ALSA: azt2320: Use standard print API
ALSA: cmi8328: Use standard print API
ALSA: cmi8330: Use standard print API
ALSA: cs4236: Use standard print API
ALSA: es1688: Use standard print API
ALSA: es18xx: Use standard print API
ALSA: gus: Use standard print API
ALSA: msnd: Use standard print API
ALSA: opl3sa2: Use standard print API
ALSA: opti9xx: Use standard print API
ALSA: sb: Use standard print API
ALSA: control_led: Use dev_err()
ALSA: pcm: oss: Use pr_debug()
ALSA: sc6000: Use standard print API
ALSA: sscape: Use standard print API
ALSA: wavefront: Use standard print API
ALSA: wss: Use standard print API
ALSA: riptide: Use standard print API
ALSA: korg1212: Use standard print API
ALSA: lx6464es: Cleanup the print API usages
ALSA: azt3328: Use pr_warn()
ALSA: emu10k1: Use dev_warn()
ALSA: trident: Use standard print API
ALSA: emux: Use standard print API
ALSA: usx2y: Use standard print API
ALSA: usb-audio: Use standard print API
ALSA: intel8x0: Drop unused snd_printd() calls
ALSA: vxpocket: Use standard print API
ALSA: pdaudiocf: Use standard print API
ALSA: ppc: Use standard print API
ALSA: sh: Use standard print API
ALSA: sparc: Use standard print API
ALSA: asihpi: Use standard print API
ALSA: docs: Drop snd_print*() stuff
ALSA: core: Drop snd_print stuff and co

 Documentation/sound/hd-audio/notes.rst        |   6 -
 .../kernel-api/writing-an-alsa-driver.rst     |  25 --
 include/sound/aci.h                           |   1 +
 include/sound/core.h                          |  67 ------
 include/sound/es1688.h                        |   1 +
 include/sound/snd_wavefront.h                 |   4 -
 include/sound/soundfont.h                     |   6 +-
 include/sound/vx_core.h                       |   1 -
 sound/core/Kconfig                            |   9 -
 sound/core/control_led.c                      |   2 +-
 sound/core/misc.c                             |  71 ------
 sound/core/oss/pcm_plugin.h                   |   2 +-
 sound/drivers/aloop.c                         |   2 +-
 sound/drivers/dummy.c                         |   5 +-
 sound/drivers/mpu401/mpu401.c                 |  16 +-
 sound/drivers/mpu401/mpu401_uart.c            |  31 +--
 sound/drivers/mtpav.c                         |  14 +-
 sound/drivers/mts64.c                         |  18 +-
 sound/drivers/opl3/opl3_lib.c                 |  18 +-
 sound/drivers/opl3/opl3_midi.c                |  95 ++++----
 sound/drivers/opl3/opl3_oss.c                 |  12 +-
 sound/drivers/opl3/opl3_synth.c               |   4 +-
 sound/drivers/opl4/opl4_lib.c                 |   8 +-
 sound/drivers/opl4/yrw801.c                   |   2 +-
 sound/drivers/pcsp/pcsp.c                     |  21 +-
 sound/drivers/pcsp/pcsp_lib.c                 |  38 ++--
 sound/drivers/pcsp/pcsp_mixer.c               |   2 +-
 sound/drivers/portman2x4.c                    |  19 +-
 sound/drivers/serial-u16550.c                 |  41 ++--
 sound/drivers/virmidi.c                       |   8 +-
 sound/drivers/vx/vx_core.c                    |  64 +++---
 sound/drivers/vx/vx_hwdep.c                   |   4 +-
 sound/drivers/vx/vx_pcm.c                     |  23 +-
 sound/drivers/vx/vx_uer.c                     |   3 +-
 sound/i2c/cs8427.c                            |  37 +--
 sound/i2c/other/ak4113.c                      |   2 -
 sound/i2c/other/ak4114.c                      |  12 -
 sound/i2c/other/ak4117.c                      |  13 --
 sound/i2c/other/ak4xxx-adda.c                 |   2 -
 sound/i2c/other/pt2258.c                      |   6 +-
 sound/i2c/tea6330t.c                          |   3 -
 sound/isa/ad1816a/ad1816a.c                   |  16 +-
 sound/isa/ad1816a/ad1816a_lib.c               |  16 +-
 sound/isa/als100.c                            |  16 +-
 sound/isa/azt2320.c                           |  14 +-
 sound/isa/cmi8328.c                           |  42 ++--
 sound/isa/cmi8330.c                           |  36 ++-
 sound/isa/cs423x/cs4236.c                     |  31 +--
 sound/isa/cs423x/cs4236_lib.c                 |  56 ++---
 sound/isa/es1688/es1688.c                     |   2 +-
 sound/isa/es1688/es1688_lib.c                 |  55 ++---
 sound/isa/es18xx.c                            |  87 +++----
 sound/isa/gus/gus_dma.c                       |  37 +--
 sound/isa/gus/gus_io.c                        | 215 ++++++++++++------
 sound/isa/gus/gus_irq.c                       |   7 +-
 sound/isa/gus/gus_main.c                      |  29 ++-
 sound/isa/gus/gus_mem.c                       |   2 +-
 sound/isa/gus/gus_pcm.c                       |  33 +--
 sound/isa/gus/gus_reset.c                     |   8 +-
 sound/isa/gus/gus_uart.c                      |  21 +-
 sound/isa/gus/gus_volume.c                    |   7 +-
 sound/isa/gus/gusclassic.c                    |   4 +-
 sound/isa/gus/gusextreme.c                    |   4 +-
 sound/isa/gus/gusmax.c                        |  16 +-
 sound/isa/gus/interwave.c                     |  61 ++---
 sound/isa/msnd/msnd.c                         |  46 ++--
 sound/isa/msnd/msnd_midi.c                    |   4 -
 sound/isa/msnd/msnd_pinnacle.c                | 184 +++++++--------
 sound/isa/opl3sa2.c                           |  46 ++--
 sound/isa/opti9xx/miro.c                      | 163 ++++++-------
 sound/isa/opti9xx/opti92x-ad1848.c            |  62 ++---
 sound/isa/sb/emu8000.c                        |  11 +-
 sound/isa/sb/emu8000_patch.c                  |   1 -
 sound/isa/sb/emu8000_synth.c                  |   2 +-
 sound/isa/sb/jazz16.c                         |  49 ++--
 sound/isa/sb/sb16.c                           |  42 ++--
 sound/isa/sb/sb16_csp.c                       |  38 ++--
 sound/isa/sb/sb16_main.c                      |  13 +-
 sound/isa/sb/sb8.c                            |  12 +-
 sound/isa/sb/sb_common.c                      |  27 +--
 sound/isa/sb/sb_mixer.c                       |   4 +-
 sound/isa/sc6000.c                            | 177 +++++++-------
 sound/isa/sscape.c                            |  96 ++++----
 sound/isa/wavefront/wavefront.c               |  61 ++---
 sound/isa/wavefront/wavefront_fx.c            |  36 +--
 sound/isa/wavefront/wavefront_midi.c          |  15 +-
 sound/isa/wavefront/wavefront_synth.c         | 196 ++++++++--------
 sound/isa/wss/wss_lib.c                       | 178 ++++++++-------
 sound/pci/asihpi/asihpi.c                     | 101 ++++----
 sound/pci/asihpi/hpioctl.c                    |   2 +-
 sound/pci/azt3328.c                           |   2 +-
 sound/pci/emu10k1/emu10k1_patch.c             |   5 +-
 sound/pci/intel8x0.c                          |   3 -
 sound/pci/intel8x0m.c                         |   3 -
 sound/pci/korg1212/korg1212.c                 |  30 +--
 sound/pci/lx6464es/lx_core.c                  |   8 +-
 sound/pci/lx6464es/lx_core.h                  |   3 -
 sound/pci/riptide/riptide.c                   | 193 ++++++++--------
 sound/pci/trident/trident_memory.c            |  10 +-
 sound/pcmcia/pdaudiocf/pdaudiocf.c            |  21 +-
 sound/pcmcia/pdaudiocf/pdaudiocf_core.c       |  36 +--
 sound/pcmcia/pdaudiocf/pdaudiocf_irq.c        |   3 +-
 sound/pcmcia/vx/vxp_ops.c                     |  10 +-
 sound/pcmcia/vx/vxpocket.c                    |  25 +-
 sound/ppc/awacs.c                             |   4 +-
 sound/ppc/daca.c                              |   2 +-
 sound/ppc/keywest.c                           |   5 +-
 sound/ppc/pmac.c                              |  52 ++---
 sound/ppc/powermac.c                          |   2 +-
 sound/ppc/tumbler.c                           |  21 +-
 sound/sh/aica.c                               |   7 +-
 sound/sh/sh_dac_audio.c                       |   8 +-
 sound/sparc/amd7930.c                         |   8 +-
 sound/sparc/cs4231.c                          |  78 ++++---
 sound/synth/emux/emux_hwdep.c                 |   6 +-
 sound/synth/emux/emux_oss.c                   |  11 +-
 sound/synth/emux/emux_seq.c                   |  13 +-
 sound/synth/emux/emux_synth.c                 |  12 +-
 sound/synth/emux/soundfont.c                  |  67 +++---
 sound/usb/midi.c                              |   6 +-
 sound/usb/usx2y/us122l.c                      |  45 ++--
 sound/usb/usx2y/usX2Yhwdep.c                  |  25 +-
 sound/usb/usx2y/usb_stream.c                  |  92 ++++----
 sound/usb/usx2y/usb_stream.h                  |   1 +
 sound/usb/usx2y/usbusx2y.c                    |   7 +-
 sound/usb/usx2y/usbusx2yaudio.c               |  67 +++---
 sound/usb/usx2y/usx2yhwdeppcm.c               |  54 +++--
 127 files changed, 1950 insertions(+), 2094 deletions(-)
Signature · 1 line
2.43.0