Skip to content

kthread: Introduce preferred affinity v2

Frederic Weisbecker linux-arm-kernel linux-scsi linuxppc-dev lkml rcu 1 version Applied

Status from this message: The following commit has been merged into the x86/cache branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/19arm/bL_switcher: Use kthread_run_on_cpu()arch/arm/common/bL_switcher.c+4 -60 replies
2/19x86/resctrl: Use kthread_run_on_cpu()arch/x86/kernel/cpu/resctrl/pseudo_lock.c+8 -200 replies
3/19firmware: stratix10-svc: Use kthread_run_on_cpu()drivers/firmware/stratix10-svc.c+3 -60 replies
4/19scsi: bnx2fc: Use kthread_create_on_cpu()drivers/scsi/bnx2fc/bnx2fc_fcoe.c+2 -50 replies
5/19scsi: bnx2i: Use kthread_create_on_cpu()drivers/scsi/bnx2i/bnx2i_init.c+2 -50 replies
6/19scsi: qedi: Use kthread_create_on_cpu()drivers/scsi/qedi/qedi_main.c+2 -40 replies
7/19soc/qman: test: Use kthread_run_on_cpu()drivers/soc/fsl/qbman/qman_test_stash.c+2 -40 replies
8/19kallsyms: Use kthread_run_on_cpu()kernel/kallsyms_selftest.c+1 -30 replies
9/19lib: test_objpool: Use kthread_run_on_cpu()lib/test_objpool.c+5 -141 reply
10/19net: pktgen: Use kthread_create_on_node()net/core/pktgen.c+2 -50 replies
11/19kthread: Make sure kthread hasn't started while binding itkernel/kthread.c+7 -00 replies
12/19kthread: Default affine kthread to its preferred NUMA nodeinclude/linux/cpuhotplug.h kernel/kthread.c+120 -11 reply
13/19mm: Create/affine kcompactd to its preferred nodemm/compaction.c+3 -401 reply
14/19mm: Create/affine kswapd to its preferred nodemm/vmscan.c+2 -51 reply
15/19kthread: Implement preferred affinityinclude/linux/kthread.h kernel/kthread.c+62 -80 replies
16/19rcu: Use kthread preferred affinity for RCU boostkernel/rcu/tree.c kernel/rcu/tree_plugin.h+21 -170 replies
17/19kthread: Unify kthread_create_on_cpu() and kthread_create_worker_on_cpu() automatic formatfs/erofs/zdata.c include/linux/kthread.h kernel/kthread.c+52 -300 replies
18/19treewide: Introduce kthread_run_worker[_on_cpu]()arch/x86/kvm/i8254.c crypto/crypto_engine.c drivers/cpufreq/cppc_cpufreq.c +29 more+82 -650 replies
19/19rcu: Use kthread preferred affinity for RCU exp kworkerskernel/rcu/tree.c+19 -860 replies

Reviews trailers per patch

10 of 19 patches have a Reviewed-by or Acked-by.

PatchDave MartinNicolas PitreReinette ChatreVlastimil BabkaPaul E. McKenneyMatt Wu
1/19R-b A-b
2/19A-b
3/19
4/19
5/19
6/19
7/19
8/19
9/19R-b
10/19
11/19A-b
12/19A-b
13/19A-b
14/19A-b
15/19A-b
16/19A-b
17/19
18/19
19/19A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH 00/19] kthread: Introduce preferred affinity v2

Affining kthreads follow either of three existing different patterns:

1) Per-CPU kthreads must stay affine to a single CPU and never execute relevant code on any other CPU. This is currently handled by smpboot code which takes care of CPU-hotplug operations.

2) Kthreads that _have_ to be affine to a specific set of CPUs and can't run anywhere else. The affinity is set through kthread_bind_mask() and the subsystem takes care by itself to handle CPU-hotplug operations.

3) Kthreads that _prefer_ to be affine to a specific NUMA node.

4) Similar to the previous point but kthreads have a _preferred_ affinity different than a node. It is set manually like any other task and CPU-hotplug is supposed to be handled by the relevant subsystem so that the task is properly reaffined whenever a given CPU from the preferred affinity comes up or down. Also care must be taken so that the preferred affinity doesn't cross housekeeping cpumask boundaries.

Currently the preferred affinity patterns (3 and 4) have at least 4 identified users, with more or less success when it comes to handle CPU-hotplug operations and CPU isolation.

This is a infrastructure proposal to handle this (after cleanups from 01 to 10).

Frederic Weisbecker (19):
arm/bL_switcher: Use kthread_run_on_cpu() x86/resctrl: Use kthread_run_on_cpu()
firmware: stratix10-svc: Use kthread_run_on_cpu()
scsi: bnx2fc: Use kthread_create_on_cpu()
scsi: bnx2i: Use kthread_create_on_cpu()
scsi: qedi: Use kthread_create_on_cpu() soc/qman: test: Use kthread_run_on_cpu()
kallsyms: Use kthread_run_on_cpu()
lib: test_objpool: Use kthread_run_on_cpu()
net: pktgen: Use kthread_create_on_node()
kthread: Make sure kthread hasn't started while binding it
kthread: Default affine kthread to its preferred NUMA node
mm: Create/affine kcompactd to its preferred node
mm: Create/affine kswapd to its preferred node
kthread: Implement preferred affinity
rcu: Use kthread preferred affinity for RCU boost
kthread: Unify kthread_create_on_cpu() and
kthread_create_worker_on_cpu() automatic format
treewide: Introduce kthread_run_worker[_on_cpu]()
rcu: Use kthread preferred affinity for RCU exp kworkers

 arch/arm/common/bL_switcher.c                 |  10 +-
 arch/x86/kernel/cpu/resctrl/pseudo_lock.c     |  28 +--
 arch/x86/kvm/i8254.c                          |   2 +-
 crypto/crypto_engine.c                        |   2 +-
 drivers/cpufreq/cppc_cpufreq.c                |   2 +-
 drivers/firmware/stratix10-svc.c              |   9 +-
 drivers/gpu/drm/drm_vblank_work.c             |   2 +-
 .../drm/i915/gem/selftests/i915_gem_context.c |   2 +-
 drivers/gpu/drm/i915/gt/selftest_execlists.c  |   2 +-
 drivers/gpu/drm/i915/gt/selftest_hangcheck.c  |   2 +-
 drivers/gpu/drm/i915/gt/selftest_slpc.c       |   2 +-
 drivers/gpu/drm/i915/selftests/i915_request.c |   8 +-
 drivers/gpu/drm/msm/disp/msm_disp_snapshot.c  |   2 +-
 drivers/gpu/drm/msm/msm_atomic.c              |   2 +-
 drivers/gpu/drm/msm/msm_gpu.c                 |   2 +-
 drivers/gpu/drm/msm/msm_kms.c                 |   2 +-
 .../platform/chips-media/wave5/wave5-vpu.c    |   2 +-
 drivers/net/dsa/mv88e6xxx/chip.c              |   2 +-
 drivers/net/ethernet/intel/ice/ice_dpll.c     |   2 +-
 drivers/net/ethernet/intel/ice/ice_gnss.c     |   2 +-
 drivers/net/ethernet/intel/ice/ice_ptp.c      |   2 +-
 drivers/platform/chrome/cros_ec_spi.c         |   2 +-
 drivers/ptp/ptp_clock.c                       |   2 +-
 drivers/scsi/bnx2fc/bnx2fc_fcoe.c             |   7 +-
 drivers/scsi/bnx2i/bnx2i_init.c               |   7 +-
 drivers/scsi/qedi/qedi_main.c                 |   6 +-
 drivers/soc/fsl/qbman/qman_test_stash.c       |   6 +-
 drivers/spi/spi.c                             |   2 +-
 drivers/usb/typec/tcpm/tcpm.c                 |   2 +-
 drivers/vdpa/vdpa_sim/vdpa_sim.c              |   2 +-
 drivers/watchdog/watchdog_dev.c               |   2 +-
 fs/erofs/zdata.c                              |   2 +-
 include/linux/cpuhotplug.h                    |   1 +
 include/linux/kthread.h                       |  56 ++++-
 kernel/kallsyms_selftest.c                    |   4 +-
 kernel/kthread.c                              | 214 ++++++++++++++++--
 kernel/rcu/tree.c                             |  94 ++------
 kernel/rcu/tree_plugin.h                      |  11 +-
 kernel/workqueue.c                            |   2 +-
 lib/test_objpool.c                            |  19 +-
 mm/compaction.c                               |  43 +---
 mm/vmscan.c                                   |   7 +-
 net/core/pktgen.c                             |   7 +-
 net/dsa/tag_ksz.c                             |   2 +-
 net/dsa/tag_ocelot_8021q.c                    |   2 +-
 net/dsa/tag_sja1105.c                         |   2 +-
 46 files changed, 334 insertions(+), 259 deletions(-)
Signature · 1 line
2.45.2