Skip to content

do_numa_page(),do_huge_pmd_numa_page() fix and cleanup

Zi Yan linux-mm lkml stable 2 versions – Applied

Status from this message: [merged mm-stable] mm-migrate-move-common-code-to-numa_migrate_check-was-numa_migrate_prep.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 5 repliesApplied 3/3
  2. v12 patches 18 repliesSuperseded

Patches in v3 All 3 applied

#Subject and filesSizeRepliesApplied
1/3mm/numa: no task_numa_fault() call if PTE is changedmm/memory.c+16 -171 replyApplied
2/3mm/numa: no task_numa_fault() call if PMD is changedmm/huge_memory.c+13 -161 replyApplied
3/3mm/migrate: move common code to numa_migrate_check (was numa_migrate_prep)mm/huge_memory.c mm/internal.h mm/memory.c+47 -503 repliesApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchHuang, YingBaolin WangDavid Hildenbrand
1/3A-b
2/3A-b
3/3R-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/3] do_numa_page(),do_huge_pmd_numa_page() fix and cleanup

Changes from v1[1] and v2(Patch 2 only)[2]
===
1. Patch 1: Separated do_numa_page() and do_huge_pmd_numa_page() fixes, since the issues are introduced by two separate commits.

2. Patch 1: Moved migration failure branch code and called task_numa_fault() and return immediately when migration succeedds. (per Huang, Ying)

3. Patch 2: change do_huge_pmd_numa_page() to match do_numa_page() in terms of page table entry manipulation (per Huang, Ying)

4. Patch 1: Restructured the code (per Kefeng Wang)

5. Patch 1: Returned immediately when page table entries do not match instead of using goto (per David Hildenbrand)

[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/linux-mm/[email protected]/

Zi Yan (3):
mm/numa: no task_numa_fault() call if PTE is changed mm/numa: no task_numa_fault() call if PMD is changed mm/migrate: move common code to numa_migrate_check (was
numa_migrate_prep)

 mm/huge_memory.c | 56 ++++++++++++----------------
 mm/internal.h    |  5 ++-
 mm/memory.c      | 96 ++++++++++++++++++++++++------------------------
 3 files changed, 75 insertions(+), 82 deletions(-)
Signature · 1 line
2.43.0