net/mlx5: fix reported Rx/Tx desc limits
Get series with b4
b4 am [email protected]Versions newest first
- v3 Latest2 patches 5 repliesIn review
Changes in v3 from the cover letter
* Added uint8_t optimization
* Fixed commit messages
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | net/mlx5: fix reported Rx/Tx desc limitsdrivers/ drivers/ drivers/ +2 more | +22 | 1 reply | |
| 2/2 | common/mlx5: reduce HCA attribute type sizesdrivers/ | +4 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Viacheslav Ovsiienko |
|---|---|
| 1/2 | A-b |
| 2/2 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits
Hi, Slava
Quoted 6 lines
Quoted 3 lines
Is an
intappropriate forlog_max_wq_sz? Seems like auint8_tis sufficient, but I've left it anintfor consistency with the otherlog_max_*values.Right,
uint8_tlooks to be enough. No objection to optimize others touint8_t.
Changed log_max_wq_sz to uint8_t in the main patch. The others are changed in a separate patch. Let me know if it'd be preferrable to squash the patches.
Quoted 10 lines
Quoted 6 lines
Quoted 2 lines
4. Please, format your patch according to the "fix" template.
I've reworded the commit message a little bit. But I don't see these issues on Bugzilla, I've stumbled upon them independently. If you'd like the bug reports to be created, let me know.
I meant this: https://doc.dpdk.org/guides/contributing/patches.html
Please see chapter "8.7. Commit Messages: Body" about "Fixes" and "Cc:
[email protected]".
It is a bit difficult for me to reference a commit for the "Fixes", since it's a bit hard to call this a regression specifically. I set this tag to the commit that first introduced configuring the device. Is that appropriate?
Quoted 3 lines
Also, please run checking script: /devtools/check-git-log.sh' -1 to verify commit message compliance.
Thanks! No warnings now, except for "Wrong headline prefix" for the first patch because it modifies both common/mlx5 and net/mlx5. I can split the patch into two if needed.
v3:
* Added uint8_t optimization
* Fixed commit messages
v2:
* Patch reworked to query HCA attributes
Igor Gutorov (2):
net/mlx5: fix reported Rx/Tx desc limits
common/mlx5: reduce HCA attribute type sizes
drivers/common/mlx5/mlx5_devx_cmds.c | 1 + drivers/common/mlx5/mlx5_devx_cmds.h | 9 +++++---- drivers/net/mlx5/mlx5_ethdev.c | 4 ++++ drivers/net/mlx5/mlx5_rxq.c | 8 ++++++++ drivers/net/mlx5/mlx5_txq.c | 8 ++++++++ 5 files changed, 26 insertions(+), 4 deletions(-)
Signature · 1 line
2.45.2