Skip to content

OF support for Surface System Aggregator Module

Konrad Dybcio linux-acpi linux-devicetree linux-serial lkml platform-driver-x86 3 versions – In review

Get series with b4
b4 am [email protected] change-id 20240809-topic-sam-5de2f0ec9370

Versions newest first

  1. v3 Latest3 patches 15 repliesIn review
  2. v23 patches 9 repliesSuperseded
  3. v13 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- Drop unnecessary nullchecks
- Add MODULE_ALIAS in the platform hub driver
- Fix MODULE_DEVICE_TABLE after rename
- Prolong the '----' comment to 80 lines
- Change the current-speed bindings description to ": true", in preparation for krzk's serial device bindings reorganization
- Link to v2: https://lore.kernel.org/r/[email protected]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dt-bindings: serial: Allow embedded-controller as child nodeDocumentation/devicetree/bindings/serial/serial.yaml+1 -10 replies
2/3dt-bindings: platform: Add Surface System Aggregator ModuleDocumentation/devicetree/bindings/platform/microsoft,surface-sam.yaml+47 -01 reply
3/3platform/surface: Add OF supportdrivers/platform/surface/aggregator/bus.c drivers/platform/surface/aggregator/controller.c drivers/platform/surface/aggregator/core.c +3 more+162 -3810 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiMaximilian Luz
1/3R-b
2/3R-b
3/3R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] OF support for Surface System Aggregator Module

Wire up OF support for SSAM drivers, to use with Surface Laptop 7 and other Qualcomm-based devices.

Patch 3 references compatible strings introduced in [1]

[1] https://lore.kernel.org/linux-arm-msm/[email protected]/T/#u

---
Changes in v3:
- Drop unnecessary nullchecks
- Add MODULE_ALIAS in the platform hub driver
- Fix MODULE_DEVICE_TABLE after rename
- Prolong the '----' comment to 80 lines
- Change the current-speed bindings description to ": true", in preparation for krzk's serial device bindings reorganization
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Fix kerneldoc
- Drop the drivers/acpi change (oops)
- Style fixes
- Don't assign int to acpi_status
- Don't scan the bus twice in SAM core probe
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Konrad Dybcio (3):
dt-bindings: serial: Allow embedded-controller as child node
dt-bindings: platform: Add Surface System Aggregator Module platform/surface: Add OF support

 .../bindings/platform/microsoft,surface-sam.yaml   | 47 +++++++++++++
 .../devicetree/bindings/serial/serial.yaml         |  2 +-
 drivers/platform/surface/aggregator/bus.c          |  2 +
 drivers/platform/surface/aggregator/controller.c   | 67 ++++++++++++++----
 drivers/platform/surface/aggregator/core.c         | 82 +++++++++++++++++-----
 drivers/platform/surface/surface3_power.c          |  1 +
 drivers/platform/surface/surface_acpi_notify.c     |  1 +
 .../platform/surface/surface_aggregator_registry.c | 47 +++++++++++--
 8 files changed, 210 insertions(+), 39 deletions(-)

---
base-commit: 1e391b34f6aa043c7afa40a2103163a0ef06d179
change-id: 20240809-topic-sam-5de2f0ec9370

Best regards,

Signature · 1 line
Konrad Dybcio <[email protected]>