NBD: tune handshake timeout
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | qemu-nbd: Allow users to adjust handshake limitdocs/ qemu-nbd.c | +31 | 1 reply | |
| 2/2 | nbd/server: Allow users to adjust handshake limit in QMPblock/ blockdev-nbd.c include/ +1 more | +33 | 5 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Vladimir Sementsov-Ogievskiy |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH for-9.2 0/2] NBD: tune handshake timeout
Originally posted as the tail part of this v4 series:
https://lists.gnu.org/archive/html/qemu-devel/2024-08/msg01154.html
but not deemed necessary for 9.1 as it is a feature addition that was not proposed before soft freeze (even if the point of the feature is to enable interop testing to revert back to 9.0 behavior allowing for unlimited time when debuging an NBD_OPT interchange under gdb).
As part of closing out the CVE, where the v4 patches used handshake_limit, the actual pull request used handshake_max_secs (a bit more self-documenting); I rebased that rename into the QMP code, but prefer to keep the qemu-nbd command-line spelling shorter. But I'm open to any arguments on why the names should be the same, or on any other better spellings to expose to the user.
Eric Blake (2):
qemu-nbd: Allow users to adjust handshake limit nbd/server: Allow users to adjust handshake limit in QMP
docs/tools/qemu-nbd.rst | 5 +++++ qapi/block-export.json | 10 +++++++++ include/block/nbd.h | 6 ++--- block/monitor/block-hmp-cmds.c | 4 ++-- blockdev-nbd.c | 26 ++++++++++++++------- qemu-nbd.c | 41 +++++++++++++++++++++------------- 6 files changed, 64 insertions(+), 28 deletions(-)
Signature · 1 line
2.46.0