Fix error paths in driver load
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest11 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | drm/xe: use devm instead of drmm for managed bodrivers/ | +3 | 0 replies | |
| 2/11 | drm/xe/uc: Use managed bo for HuC and GSC objectsdrivers/ drivers/ drivers/ | +14 | 0 replies | |
| 3/11 | drm/xe/uc: Use devm to register cleanup that includes exec_queuesdrivers/ drivers/ | +4 | 0 replies | |
| 4/11 | drm/xe: Fix tile fini sequencedrivers/ | +4 | 0 replies | |
| 5/11 | drm/xe: Add driver load error injectiondrivers/ drivers/ drivers/ +16 more | +135 | 0 replies | |
| 6/11 | drm/xe: Move ggtt_fini to devm manageddrivers/ | +2 | 0 replies | |
| 7/11 | drm/xe: Set firmware state to loadable before registering guc_fini_hwdrivers/ | +2 | 0 replies | |
| 8/11 | drm/xe: Drop warn on xe_guc_pc_gucrc_disable in guc pc finidrivers/ | +1 | 0 replies | |
| 9/11 | drm/xe: Move hw_engine_fini to devm manageddrivers/ | +2 | 0 replies | |
| 10/11 | drm/xe: Move HuC init before GuC initdrivers/ | +4 | 0 replies | |
| 11/11 | drm/xe: Update xe_sa to use xe_managed_bo_create_pin_mapdrivers/ drivers/ | +7 | 0 replies |
Reviews trailers per patch
3 of 11 patches have a Reviewed-by or Acked-by.
| Patch | Matthew Brost |
|---|---|
| 1/11 | R-b |
| 2/11 | R-b |
| 3/11 | R-b |
| 4/11 | |
| 5/11 | |
| 6/11 | |
| 7/11 | |
| 8/11 | |
| 9/11 | |
| 10/11 | |
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/11] Fix error paths in driver load
Combine a few series [1] [2] [3] plus some new patches to get driver into working state.
The below test case passed on TGL:
for i in {1..19}; do echo "Run $i"; modprobe xe inject_driver_load_error=$i; rmmod xe; done
More error injection points should be added, likely 100s more. Posted to likely hand off this work to a team member in a working state.
Matt
[1] https://patchwork.freedesktop.org/series/137113/
[2] https://patchwork.freedesktop.org/series/137112/
[3] https://patchwork.freedesktop.org/series/137111/
Daniele Ceraolo Spurio (3):
drm/xe: use devm instead of drmm for managed bo drm/xe/uc: Use managed bo for HuC and GSC objects drm/xe/uc: Use devm to register cleanup that includes exec_queues
Matthew Brost (8):
drm/xe: Fix tile fini sequence
drm/xe: Add driver load error injection
drm/xe: Move ggtt_fini to devm managed
drm/xe: Set firmware state to loadable before registering guc_fini_hw drm/xe: Drop warn on xe_guc_pc_gucrc_disable in guc pc fini drm/xe: Move hw_engine_fini to devm managed
drm/xe: Move HuC init before GuC init
drm/xe: Update xe_sa to use xe_managed_bo_create_pin_map
drivers/gpu/drm/xe/xe_bo.c | 6 ++--- drivers/gpu/drm/xe/xe_device.c | 31 ++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_device.h | 15 ++++++++++++ drivers/gpu/drm/xe/xe_device_types.h | 4 ++++ drivers/gpu/drm/xe/xe_ggtt.c | 4 ++-- drivers/gpu/drm/xe/xe_gsc.c | 16 ++++--------- drivers/gpu/drm/xe/xe_gsc_proxy.c | 36 +++++----------------------- drivers/gpu/drm/xe/xe_gt.c | 5 ++++ drivers/gpu/drm/xe/xe_gt_sriov_pf.c | 4 ++++ drivers/gpu/drm/xe/xe_guc.c | 12 ++++++++-- drivers/gpu/drm/xe/xe_guc_ads.c | 5 ++++ drivers/gpu/drm/xe/xe_guc_ct.c | 4 ++++ drivers/gpu/drm/xe/xe_guc_log.c | 5 ++++ drivers/gpu/drm/xe/xe_guc_pc.c | 2 +- drivers/gpu/drm/xe/xe_guc_submit.c | 4 ++-- drivers/gpu/drm/xe/xe_huc.c | 19 ++++----------- drivers/gpu/drm/xe/xe_hw_engine.c | 4 ++-- drivers/gpu/drm/xe/xe_mmio.c | 10 +++++++- drivers/gpu/drm/xe/xe_module.c | 5 ++++ drivers/gpu/drm/xe/xe_module.h | 3 +++ drivers/gpu/drm/xe/xe_pci.c | 9 +++++++ drivers/gpu/drm/xe/xe_pm.c | 8 +++++++ drivers/gpu/drm/xe/xe_sa.c | 13 +++++----- drivers/gpu/drm/xe/xe_sa_types.h | 1 + drivers/gpu/drm/xe/xe_sriov.c | 8 ++++++- drivers/gpu/drm/xe/xe_tile.c | 4 ++++ drivers/gpu/drm/xe/xe_uc.c | 12 ++++++---- drivers/gpu/drm/xe/xe_wa.c | 5 ++++ drivers/gpu/drm/xe/xe_wopcm.c | 4 ++++ 29 files changed, 178 insertions(+), 80 deletions(-)
Signature · 1 line
2.34.1