Skip to content

Fix error paths in driver load

Matthew Brost intel-xe 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/xe: use devm instead of drmm for managed bodrivers/gpu/drm/xe/xe_bo.c+3 -30 replies
2/11drm/xe/uc: Use managed bo for HuC and GSC objectsdrivers/gpu/drm/xe/xe_gsc.c drivers/gpu/drm/xe/xe_gsc_proxy.c drivers/gpu/drm/xe/xe_huc.c+14 -530 replies
3/11drm/xe/uc: Use devm to register cleanup that includes exec_queuesdrivers/gpu/drm/xe/xe_gsc.c drivers/gpu/drm/xe/xe_guc_submit.c+4 -40 replies
4/11drm/xe: Fix tile fini sequencedrivers/gpu/drm/xe/xe_mmio.c+4 -10 replies
5/11drm/xe: Add driver load error injectiondrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_device.h drivers/gpu/drm/xe/xe_device_types.h +16 more+135 -10 replies
6/11drm/xe: Move ggtt_fini to devm manageddrivers/gpu/drm/xe/xe_ggtt.c+2 -20 replies
7/11drm/xe: Set firmware state to loadable before registering guc_fini_hwdrivers/gpu/drm/xe/xe_guc.c+2 -20 replies
8/11drm/xe: Drop warn on xe_guc_pc_gucrc_disable in guc pc finidrivers/gpu/drm/xe/xe_guc_pc.c+1 -10 replies
9/11drm/xe: Move hw_engine_fini to devm manageddrivers/gpu/drm/xe/xe_hw_engine.c+2 -20 replies
10/11drm/xe: Move HuC init before GuC initdrivers/gpu/drm/xe/xe_uc.c+4 -40 replies
11/11drm/xe: Update xe_sa to use xe_managed_bo_create_pin_mapdrivers/gpu/drm/xe/xe_sa.c drivers/gpu/drm/xe/xe_sa_types.h+7 -70 replies

Reviews trailers per patch

3 of 11 patches have a Reviewed-by or Acked-by.

PatchMatthew Brost
1/11R-b
2/11R-b
3/11R-b
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] Fix error paths in driver load

Combine a few series [1] [2] [3] plus some new patches to get driver into working state.

The below test case passed on TGL:
for i in {1..19}; do echo "Run $i"; modprobe xe inject_driver_load_error=$i; rmmod xe; done

More error injection points should be added, likely 100s more. Posted to likely hand off this work to a team member in a working state.

Matt

[1] https://patchwork.freedesktop.org/series/137113/
[2] https://patchwork.freedesktop.org/series/137112/
[3] https://patchwork.freedesktop.org/series/137111/

Daniele Ceraolo Spurio (3):
drm/xe: use devm instead of drmm for managed bo drm/xe/uc: Use managed bo for HuC and GSC objects drm/xe/uc: Use devm to register cleanup that includes exec_queues

Matthew Brost (8):
drm/xe: Fix tile fini sequence
drm/xe: Add driver load error injection
drm/xe: Move ggtt_fini to devm managed
drm/xe: Set firmware state to loadable before registering guc_fini_hw drm/xe: Drop warn on xe_guc_pc_gucrc_disable in guc pc fini drm/xe: Move hw_engine_fini to devm managed
drm/xe: Move HuC init before GuC init
drm/xe: Update xe_sa to use xe_managed_bo_create_pin_map

 drivers/gpu/drm/xe/xe_bo.c           |  6 ++---
 drivers/gpu/drm/xe/xe_device.c       | 31 ++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_device.h       | 15 ++++++++++++
 drivers/gpu/drm/xe/xe_device_types.h |  4 ++++
 drivers/gpu/drm/xe/xe_ggtt.c         |  4 ++--
 drivers/gpu/drm/xe/xe_gsc.c          | 16 ++++---------
 drivers/gpu/drm/xe/xe_gsc_proxy.c    | 36 +++++-----------------------
 drivers/gpu/drm/xe/xe_gt.c           |  5 ++++
 drivers/gpu/drm/xe/xe_gt_sriov_pf.c  |  4 ++++
 drivers/gpu/drm/xe/xe_guc.c          | 12 ++++++++--
 drivers/gpu/drm/xe/xe_guc_ads.c      |  5 ++++
 drivers/gpu/drm/xe/xe_guc_ct.c       |  4 ++++
 drivers/gpu/drm/xe/xe_guc_log.c      |  5 ++++
 drivers/gpu/drm/xe/xe_guc_pc.c       |  2 +-
 drivers/gpu/drm/xe/xe_guc_submit.c   |  4 ++--
 drivers/gpu/drm/xe/xe_huc.c          | 19 ++++-----------
 drivers/gpu/drm/xe/xe_hw_engine.c    |  4 ++--
 drivers/gpu/drm/xe/xe_mmio.c         | 10 +++++++-
 drivers/gpu/drm/xe/xe_module.c       |  5 ++++
 drivers/gpu/drm/xe/xe_module.h       |  3 +++
 drivers/gpu/drm/xe/xe_pci.c          |  9 +++++++
 drivers/gpu/drm/xe/xe_pm.c           |  8 +++++++
 drivers/gpu/drm/xe/xe_sa.c           | 13 +++++-----
 drivers/gpu/drm/xe/xe_sa_types.h     |  1 +
 drivers/gpu/drm/xe/xe_sriov.c        |  8 ++++++-
 drivers/gpu/drm/xe/xe_tile.c         |  4 ++++
 drivers/gpu/drm/xe/xe_uc.c           | 12 ++++++----
 drivers/gpu/drm/xe/xe_wa.c           |  5 ++++
 drivers/gpu/drm/xe/xe_wopcm.c        |  4 ++++
 29 files changed, 178 insertions(+), 80 deletions(-)
Signature · 1 line
2.34.1