Skip to content

iio: bmi323: have the peripheral consume less power

Denis Benato linux-iio lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest1 patch 3 repliesIn review
  2. v2 posting 2/21 patch 1 replySuperseded
  3. v2 posting 1/20 of 1 patch 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch1 replySuperseded

Changelog from the cover letter

- V2: patch 1:
+ change patch commit message
+ drop removal callbacks and use devm_add_action_or_reset
+ split bmi323_init in two functions
+ separate regs to save and relative value
+ drop unhelpful consts ptr modifiers
+ add a comment to explain why BMI323_FIFO_CTRL_REG is being used in runtime resume
- V3: patch 1:
+ drop a struct array and replace with an array of unsigned int: u8 was too small and it would have resulted in overflow of register addresses
+ use single-line comments where possible
+ drop useless comments
+ remove intermediate variables
+ remove blank lines

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1iio: bmi323: peripheral in lowest power state on suspenddrivers/iio/imu/bmi323/bmi323_core.c+153 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/1] iio: bmi323: have the peripheral consume less power

The bmi323 chip is part of handhelds PCs that are run on battery.

One of said PC is well-known for its short battery life, even in s2idle:
help mitigate that by putting the device in its lowest-consumption state while the peripheral is unused.

Have runtime-pm suspend callback save used configuration registers and runtime-pm resume callback restore saved registers to restore the previous state.

Changelog:
- V2: patch 1:
+ change patch commit message
+ drop removal callbacks and use devm_add_action_or_reset
+ split bmi323_init in two functions
+ separate regs to save and relative value
+ drop unhelpful consts ptr modifiers
+ add a comment to explain why BMI323_FIFO_CTRL_REG is being used in runtime resume
- V3: patch 1:
+ drop a struct array and replace with an array of unsigned int: u8 was too small and it would have resulted in overflow of register addresses
+ use single-line comments where possible
+ drop useless comments
+ remove intermediate variables
+ remove blank lines

Previous patches obsoleted:
https://lore.kernel.org/all/[email protected]
https://lore.kernel.org/all/[email protected]

Denis Benato (1):
iio: bmi323: peripheral in lowest power state on suspend

 drivers/iio/imu/bmi323/bmi323_core.c | 155 ++++++++++++++++++++++++++-
 1 file changed, 153 insertions(+), 2 deletions(-)
Signature · 1 line
2.46.0