Skip to content

ASoC: Intel: Remove skylake driver

Cezary Rojewski alsa-devel linux-sound 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 5 repliesIn review
  2. v112 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- added two new patches (leading the series)
- the first moves all device entries previously under the skylake-driver dependency under the avs-driver
- the second patch drops struct skl_machine_pdata usage to fix compilation errors as pointed out by IKP
- no further changes, retained Acked-by tags for these

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14ALSA: hda: Move SST device entries to AVSsound/hda/intel-dsp-config.c+50 -612 replies
2/14ASoC: Intel: Drop skl_machine_pdata usagesound/soc/intel/common/soc-acpi-intel-cnl-match.c sound/soc/intel/common/soc-acpi-intel-ehl-match.c sound/soc/intel/common/soc-acpi-intel-hda-match.c +3 more+0 -350 replies
3/14ASoC: Intel: Remove bxt_rt298 board driversound/soc/intel/boards/Kconfig sound/soc/intel/boards/Makefile sound/soc/intel/boards/bxt_rt298.c+0 -6860 replies
4/14ASoC: Intel: Remove bxt_da7219_max98357a board driversound/soc/intel/boards/Kconfig sound/soc/intel/boards/Makefile sound/soc/intel/boards/bxt_da7219_max98357a.c+0 -7380 replies
5/14ASoC: Intel: Remove kbl_rt5663_rt5514_max98927 board driversound/soc/intel/boards/Kconfig sound/soc/intel/boards/Makefile sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c+0 -8880 replies
6/14ASoC: Intel: Remove kbl_rt5663_max98927 board driversound/soc/intel/boards/Kconfig sound/soc/intel/boards/Makefile sound/soc/intel/boards/kbl_rt5663_max98927.c+0 -10900 replies
7/14ASoC: Intel: Remove kbl_rt5660 board driversound/soc/intel/boards/Kconfig sound/soc/intel/boards/Makefile sound/soc/intel/boards/kbl_rt5660.c+0 -5810 replies
8/14ASoC: Intel: Remove kbl_da7219_max98927 board driversound/soc/intel/boards/Kconfig sound/soc/intel/boards/Makefile sound/soc/intel/boards/kbl_da7219_max98927.c+0 -11920 replies
9/14ASoC: Intel: Remove kbl_da7219_max98357a board driversound/soc/intel/boards/Kconfig sound/soc/intel/boards/Makefile sound/soc/intel/boards/kbl_da7219_max98357a.c+0 -7040 replies
10/14ASoC: Intel: Remove skl_rt286 board driversound/soc/intel/boards/Kconfig sound/soc/intel/boards/Makefile sound/soc/intel/boards/skl_rt286.c+0 -5830 replies
11/14ASoC: Intel: Remove skl_nau88l25_ssm4567 board driversound/soc/intel/boards/Kconfig sound/soc/intel/boards/Makefile sound/soc/intel/boards/skl_nau88l25_ssm4567.c+0 -7670 replies
12/14ASoC: Intel: Remove skl_nau88l25_max98357a board driversound/soc/intel/boards/Kconfig sound/soc/intel/boards/Makefile sound/soc/intel/boards/skl_nau88l25_max98357a.c+0 -7240 replies
13/14ASoC: Intel: Remove skylake driversound/soc/intel/Kconfig sound/soc/intel/Makefile sound/soc/intel/boards/Kconfig +24 more+2 -148210 replies
14/14ASoC: Intel: avs: Enable by default for all SST configurationssound/soc/intel/avs/core.c+7 -10 replies

Reviews trailers per patch

13 of 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy ShevchenkoTakashi Iwai
SeriesA-b
1/14R-b
2/14
3/14A-b
4/14A-b
5/14A-b
6/14A-b
7/14A-b
8/14A-b
9/14A-b
10/14A-b
11/14A-b
12/14A-b
13/14A-b
14/14A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/14] ASoC: Intel: Remove skylake driver

A spiritual successor to haswell/baytrail removal series [1].

The avs-driver found in sound/soc/intel/avs is a direct replacement to the existing skylake-driver. It covers all features supported by it and more and aligns with the recommended flows and requirements based on Windows driver equivalent.

The skylake-driver related UAPI has been removed with "ASoC: Drop soc-topology ABI v4 support" [2].

For the official kernel tree the deprecation begun with v6.0. Most skylake-drivers users moved to avs- or SOF-driver when AudioDSP capabilities are available on the platform or to snd-hda-intel (sound/pci/hda) when such capabilities are not.

For the supported trees the deprecation begun with v5.4 with v5.15 being the first where the skylake-driver is disabled entirely.

All machine board drivers that consume this DSP driver have their replacements present within sound/soc/intel/avs/boards/ directory.

Changes in v2:
- added two new patches (leading the series)
- the first moves all device entries previously under the skylake-driver dependency under the avs-driver
- the second patch drops struct skl_machine_pdata usage to fix compilation errors as pointed out by IKP
- no further changes, retained Acked-by tags for these

[1]: https://lore.kernel.org/alsa-devel/[email protected]/
[2]: https://lore.kernel.org/alsa-devel/[email protected]/

Cezary Rojewski (14):
ALSA: hda: Move SST device entries to AVS
ASoC: Intel: Drop skl_machine_pdata usage
ASoC: Intel: Remove bxt_rt298 board driver
ASoC: Intel: Remove bxt_da7219_max98357a board driver
ASoC: Intel: Remove kbl_rt5663_rt5514_max98927 board driver
ASoC: Intel: Remove kbl_rt5663_max98927 board driver
ASoC: Intel: Remove kbl_rt5660 board driver
ASoC: Intel: Remove kbl_da7219_max98927 board driver
ASoC: Intel: Remove kbl_da7219_max98357a board driver
ASoC: Intel: Remove skl_rt286 board driver
ASoC: Intel: Remove skl_nau88l25_ssm4567 board driver
ASoC: Intel: Remove skl_nau88l25_max98357a board driver
ASoC: Intel: Remove skylake driver
ASoC: Intel: avs: Enable by default for all SST configurations

 sound/hda/intel-dsp-config.c                  |  111 +-
 sound/soc/intel/Kconfig                       |  120 -
 sound/soc/intel/Makefile                      |    1 -
 sound/soc/intel/avs/core.c                    |    8 +-
 sound/soc/intel/boards/Kconfig                |  152 +-
 sound/soc/intel/boards/Makefile               |   20 -
 sound/soc/intel/boards/bxt_da7219_max98357a.c |  720 ----
 sound/soc/intel/boards/bxt_rt298.c            |  670 ---
 sound/soc/intel/boards/kbl_da7219_max98357a.c |  688 ----
 sound/soc/intel/boards/kbl_da7219_max98927.c  | 1175 ------
 sound/soc/intel/boards/kbl_rt5660.c           |  567 ---
 sound/soc/intel/boards/kbl_rt5663_max98927.c  | 1073 -----
 .../intel/boards/kbl_rt5663_rt5514_max98927.c |  869 ----
 .../soc/intel/boards/skl_nau88l25_max98357a.c |  704 ----
 sound/soc/intel/boards/skl_nau88l25_ssm4567.c |  751 ----
 sound/soc/intel/boards/skl_rt286.c            |  568 ---
 .../intel/common/soc-acpi-intel-cnl-match.c   |    6 -
 .../intel/common/soc-acpi-intel-ehl-match.c   |    1 -
 .../intel/common/soc-acpi-intel-hda-match.c   |    6 -
 .../intel/common/soc-acpi-intel-icl-match.c   |    6 -
 .../intel/common/soc-acpi-intel-kbl-match.c   |   11 -
 .../intel/common/soc-acpi-intel-skl-match.c   |    5 -
 sound/soc/intel/skylake/Makefile              |   15 -
 sound/soc/intel/skylake/bxt-sst.c             |  629 ---
 sound/soc/intel/skylake/cnl-sst-dsp.c         |  266 --
 sound/soc/intel/skylake/cnl-sst-dsp.h         |  103 -
 sound/soc/intel/skylake/cnl-sst.c             |  508 ---
 sound/soc/intel/skylake/skl-debug.c           |  248 --
 sound/soc/intel/skylake/skl-i2s.h             |   87 -
 sound/soc/intel/skylake/skl-messages.c        | 1419 -------
 sound/soc/intel/skylake/skl-nhlt.c            |  269 --
 sound/soc/intel/skylake/skl-pcm.c             | 1507 -------
 sound/soc/intel/skylake/skl-ssp-clk.c         |  428 --
 sound/soc/intel/skylake/skl-ssp-clk.h         |  108 -
 sound/soc/intel/skylake/skl-sst-cldma.c       |  373 --
 sound/soc/intel/skylake/skl-sst-cldma.h       |  243 --
 sound/soc/intel/skylake/skl-sst-dsp.c         |  462 ---
 sound/soc/intel/skylake/skl-sst-dsp.h         |  256 --
 sound/soc/intel/skylake/skl-sst-ipc.c         | 1071 -----
 sound/soc/intel/skylake/skl-sst-ipc.h         |  169 -
 sound/soc/intel/skylake/skl-sst-utils.c       |  425 --
 sound/soc/intel/skylake/skl-sst.c             |  599 ---
 sound/soc/intel/skylake/skl-topology.c        | 3605 -----------------
 sound/soc/intel/skylake/skl-topology.h        |  524 ---
 sound/soc/intel/skylake/skl.c                 | 1177 ------
 sound/soc/intel/skylake/skl.h                 |  207 -
 46 files changed, 59 insertions(+), 22871 deletions(-)
 delete mode 100644 sound/soc/intel/boards/bxt_da7219_max98357a.c
 delete mode 100644 sound/soc/intel/boards/bxt_rt298.c
 delete mode 100644 sound/soc/intel/boards/kbl_da7219_max98357a.c
 delete mode 100644 sound/soc/intel/boards/kbl_da7219_max98927.c
 delete mode 100644 sound/soc/intel/boards/kbl_rt5660.c
 delete mode 100644 sound/soc/intel/boards/kbl_rt5663_max98927.c
 delete mode 100644 sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
 delete mode 100644 sound/soc/intel/boards/skl_nau88l25_max98357a.c
 delete mode 100644 sound/soc/intel/boards/skl_nau88l25_ssm4567.c
 delete mode 100644 sound/soc/intel/boards/skl_rt286.c
 delete mode 100644 sound/soc/intel/skylake/Makefile
 delete mode 100644 sound/soc/intel/skylake/bxt-sst.c
 delete mode 100644 sound/soc/intel/skylake/cnl-sst-dsp.c
 delete mode 100644 sound/soc/intel/skylake/cnl-sst-dsp.h
 delete mode 100644 sound/soc/intel/skylake/cnl-sst.c
 delete mode 100644 sound/soc/intel/skylake/skl-debug.c
 delete mode 100644 sound/soc/intel/skylake/skl-i2s.h
 delete mode 100644 sound/soc/intel/skylake/skl-messages.c
 delete mode 100644 sound/soc/intel/skylake/skl-nhlt.c
 delete mode 100644 sound/soc/intel/skylake/skl-pcm.c
 delete mode 100644 sound/soc/intel/skylake/skl-ssp-clk.c
 delete mode 100644 sound/soc/intel/skylake/skl-ssp-clk.h
 delete mode 100644 sound/soc/intel/skylake/skl-sst-cldma.c
 delete mode 100644 sound/soc/intel/skylake/skl-sst-cldma.h
 delete mode 100644 sound/soc/intel/skylake/skl-sst-dsp.c
 delete mode 100644 sound/soc/intel/skylake/skl-sst-dsp.h
 delete mode 100644 sound/soc/intel/skylake/skl-sst-ipc.c
 delete mode 100644 sound/soc/intel/skylake/skl-sst-ipc.h
 delete mode 100644 sound/soc/intel/skylake/skl-sst-utils.c
 delete mode 100644 sound/soc/intel/skylake/skl-sst.c
 delete mode 100644 sound/soc/intel/skylake/skl-topology.c
 delete mode 100644 sound/soc/intel/skylake/skl-topology.h
 delete mode 100644 sound/soc/intel/skylake/skl.c
 delete mode 100644 sound/soc/intel/skylake/skl.h
Signature · 1 line
2.25.1