Skip to content

net: xilinx: axienet: Multicast fixes and improvements

Sean Anderson linux-arm-kernel lkml netdev 3 versions – Applied

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 0 repliesApplied 5/5
  2. v25 patches 8 repliesSuperseded
  3. v14 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Rebase onto net-next/main

Patches in v3 All 5 applied

#Subject and filesSizeRepliesApplied
1/5net: xilinx: axienet: Always disable promiscuous modedrivers/net/ethernet/xilinx/xilinx_axienet_main.c+4 -00 repliesApplied
2/5net: xilinx: axienet: Fix dangling multicast addressesdrivers/net/ethernet/xilinx/xilinx_axienet.h drivers/net/ethernet/xilinx/xilinx_axienet_main.c+10 -120 repliesApplied
3/5net: xilinx: axienet: Don't print if we go into promiscuous modedrivers/net/ethernet/xilinx/xilinx_axienet_main.c+0 -20 repliesApplied
4/5net: xilinx: axienet: Don't set IFF_PROMISC in ndev->flagsdrivers/net/ethernet/xilinx/xilinx_axienet_main.c+0 -50 repliesApplied
5/5net: xilinx: axienet: Support IFF_ALLMULTIdrivers/net/ethernet/xilinx/xilinx_axienet.h drivers/net/ethernet/xilinx/xilinx_axienet_main.c+22 -140 repliesApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchSimon Horman
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/5] net: xilinx: axienet: Multicast fixes and improvements

This series has a few small patches improving the handling of multicast addresses. In particular, it makes the driver a whole lot less spammy, and adjusts things so we aren't in promiscuous mode when we have more than four multicast addresses (a common occurance on modern systems).

As the hardware has a 4-entry CAM, the ideal method would be to "pack" multiple addresses into one CAM entry. Something like:

entry.address = address[0] | address[1];
entry.mask = ~(address[0] ^ address[1]);

Which would make the entry match both addresses (along with some others that would need to be filtered in software).

Mapping addresses to entries in an efficient way is a bit tricky. If anyone knows of an in-tree example of something like this, I'd be glad to hear about it.

Changes in v3:
- Rebase onto net-next/main

Changes in v2:
- Split off IFF_PROMISC change from printing changes

Sean Anderson (5):
net: xilinx: axienet: Always disable promiscuous mode
net: xilinx: axienet: Fix dangling multicast addresses
net: xilinx: axienet: Don't print if we go into promiscuous mode
net: xilinx: axienet: Don't set IFF_PROMISC in ndev->flags
net: xilinx: axienet: Support IFF_ALLMULTI

 drivers/net/ethernet/xilinx/xilinx_axienet.h  |  3 ++
 .../net/ethernet/xilinx/xilinx_axienet_main.c | 52 +++++++++----------
 2 files changed, 29 insertions(+), 26 deletions(-)
Signature · 1 line
2.35.1.1320.gc452695387.dirty