Skip to content

Backport "make svc_stat per-net instead of global"

[email protected] linux-nfs ltp stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12NFSD: Rewrite synopsis of nfsd_percpu_counters_init()fs/nfsd/stats.c fs/nfsd/stats.h+4 -40 replies
2/12NFSD: Fix frame size warning in svc_export_parse()fs/nfsd/export.c fs/nfsd/export.h fs/nfsd/stats.h+31 -170 replies
3/12sunrpc: don't change ->sv_stats if it doesn't existnet/sunrpc/svc.c+18 -90 replies
4/12nfsd: stop setting ->pg_stats for unused statsfs/lockd/svc.c fs/nfs/callback.c fs/nfsd/nfssvc.c+0 -110 replies
5/12sunrpc: pass in the sv_stats struct through svc_create_pooledfs/nfsd/nfssvc.c include/linux/sunrpc/svc.h net/sunrpc/svc.c+12 -70 replies
6/12sunrpc: remove ->pg_stats from svc_programfs/nfsd/nfssvc.c include/linux/sunrpc/svc.h+0 -20 replies
7/12sunrpc: use the struct net as the svc proc privatenet/sunrpc/stats.c+1 -10 replies
8/12nfsd: rename NFSD_NET_* to NFSD_STATS_*fs/nfsd/netns.h fs/nfsd/nfscache.c fs/nfsd/stats.h+7 -70 replies
9/12nfsd: expose /proc/net/sunrpc/nfsd in net namespacesfs/nfsd/nfsctl.c fs/nfsd/stats.c fs/nfsd/stats.h+15 -200 replies
10/12nfsd: make all of the nfsd stats per-network namespacefs/nfsd/cache.h fs/nfsd/netns.h fs/nfsd/nfs4proc.c +7 more+69 -960 replies
11/12nfsd: remove nfsd_stats, make th_cnt a global counterfs/nfsd/nfsd.h fs/nfsd/nfssvc.c fs/nfsd/stats.c +1 more+5 -100 replies
12/12nfsd: make svc_stat per-network namespace instead of globalfs/nfsd/netns.h fs/nfsd/nfsctl.c fs/nfsd/nfssvc.c +2 more+11 -90 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchJeff Layton
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 6.6.y 00/12] Backport "make svc_stat per-net instead of global"

From: Chuck Lever <[email protected]>

Following up on:

https://lore.kernel.org/linux-nfs/[email protected]/

Here is a backport series targeting origin/linux-6.6.y that closes the information leak described in the above thread. It passes basic NFSD regression testing.

Review comments welcome.

Chuck Lever (2):
NFSD: Rewrite synopsis of nfsd_percpu_counters_init()
NFSD: Fix frame size warning in svc_export_parse()

Josef Bacik (10):
sunrpc: don't change ->sv_stats if it doesn't exist
nfsd: stop setting ->pg_stats for unused stats
sunrpc: pass in the sv_stats struct through svc_create_pooled
sunrpc: remove ->pg_stats from svc_program
sunrpc: use the struct net as the svc proc private
nfsd: rename NFSD_NET_* to NFSD_STATS_*
nfsd: expose /proc/net/sunrpc/nfsd in net namespaces
nfsd: make all of the nfsd stats per-network namespace
nfsd: remove nfsd_stats, make th_cnt a global counter
nfsd: make svc_stat per-network namespace instead of global

 fs/lockd/svc.c             |  3 --
 fs/nfs/callback.c          |  3 --
 fs/nfsd/cache.h            |  2 -
 fs/nfsd/export.c           | 32 ++++++++++----
 fs/nfsd/export.h           |  4 +-
 fs/nfsd/netns.h            | 25 +++++++++--
 fs/nfsd/nfs4proc.c         |  6 +--
 fs/nfsd/nfs4state.c        |  3 +-
 fs/nfsd/nfscache.c         | 40 ++++-------------
 fs/nfsd/nfsctl.c           | 16 +++----
 fs/nfsd/nfsd.h             |  1 +
 fs/nfsd/nfsfh.c            |  3 +-
 fs/nfsd/nfssvc.c           | 14 +++---
 fs/nfsd/stats.c            | 54 ++++++++++-------------
 fs/nfsd/stats.h            | 88 ++++++++++++++------------------------
 fs/nfsd/vfs.c              |  6 ++-
 include/linux/sunrpc/svc.h |  5 ++-
 net/sunrpc/stats.c         |  2 +-
 net/sunrpc/svc.c           | 39 +++++++++++------
 19 files changed, 163 insertions(+), 183 deletions(-)
Signature · 1 line
2.45.1