Skip to content

media: venus: Add hierarchical h.264 controls

Fritz Koenig linux-arm-msm linux-media lkml 3 versions – In review

Get series with b4
b4 am [email protected] change-id 20240814-submit-05880a074377

Versions newest first

  1. v5 Latest2 patches 1 replyIn review
  2. v42 patches 2 repliesSuperseded
  3. v32 patches 3 repliesSuperseded

Changes in v5 from the cover letter

- fixed formatting
- included reviwed by for patch 2
- Link to v4: https://lore.kernel.org/r/[email protected]

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2media: venus: Helper function for dynamically updating bitratedrivers/media/platform/qcom/venus/venc_ctrls.c+20 -140 replies
2/2media: venus: Enable h.264 hierarchical codingdrivers/media/platform/qcom/venus/core.h drivers/media/platform/qcom/venus/venc.c drivers/media/platform/qcom/venus/venc_ctrls.c+144 -230 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBryan O'DonoghueDikshita Agarwal
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] media: venus: Add hierarchical h.264 controls

v5:
- fixed formatting
- included reviwed by for patch 2
- Link to v4: https://lore.kernel.org/r/[email protected]

v4:
- addressed feedback from Dikshita
- included reviewed by for patch 1
- Link to v3: https://lore.kernel.org/r/[email protected]

v3:
- dropped reordering patch
- updated cover letter

v2:
- cover letter
- testing methodology
- Signed-off-by

V4L2 has support for encoding with hierarchical frames using the V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING* controls. This allows for specifing frame references needed for temporal scalability. Encoding a single stream with a single layer allows for the layer to be dropped and the stream to be decoded without artifacts.

ChromeOS is planning to use this feature for the L1T2 web standard[1]. This allows video conferencing apps to encode once for a clients with different performance/bandwidth capabilities. As the application is a real time encoder only P frame support is added.

The ChromeOS test framework ("tast") was used to verify that no regressions are present. This was done on SC7180 ("trogdor"). These patches were also run on SC7280, but not with as an extensive test set.

Verification of the added controls was done with a bitstream analyser to make sure that reference frame management is correct.

[1]: https://www.w3.org/TR/webrtc-svc/#L1T2*

---
Fritz Koenig (2):
media: venus: Helper function for dynamically updating bitrate
media: venus: Enable h.264 hierarchical coding

 drivers/media/platform/qcom/venus/core.h       |   4 +
 drivers/media/platform/qcom/venus/venc.c       |  71 +++++++++-----
 drivers/media/platform/qcom/venus/venc_ctrls.c | 126 ++++++++++++++++++++++---
 3 files changed, 164 insertions(+), 37 deletions(-)

---
base-commit: d07b43284ab356daf7ec5ae1858a16c1c7b6adab
change-id: 20240814-submit-05880a074377

Best regards,

Signature · 1 line
Fritz Koenig <[email protected]>