Skip to content

add meson config options for queues per port

Bruce Richardson dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest26 patches 8 repliesIn review

Changes in v3 from the cover letter

* Resend of v2 with correct author email, to avoid reply bounces
* drop "rfc" prefix from patches

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26cryptodev: remove use of ethdev max queues definitionconfig/rte_config.h lib/cryptodev/cryptodev_pmd.c+3 -21 reply
2/26eventdev: remove use of ethev queues definelib/eventdev/eventdev_private.c+1 -10 replies
3/26app/test-bbdev: remove use of ethdev queue count valueapp/test-bbdev/test_bbdev.c+2 -21 reply
4/26config: add separate defines for max Rx and Tx queuesconfig/rte_config.h doc/guides/rel_notes/release_24_11.rst+8 -03 replies
5/26ethdev: use separate Rx and Tx queue limitslib/ethdev/ethdev_driver.h lib/ethdev/ethdev_private.c lib/ethdev/rte_ethdev.c +1 more+34 -320 replies
6/26bpf: use separate Rx and Tx queue limitslib/bpf/bpf_pkt.c+2 -10 replies
7/26latencystats: use separate Rx and Tx queue limitslib/latencystats/rte_latencystats.c+2 -20 replies
8/26pdump: use separate Rx and Tx queue limitslib/pdump/rte_pdump.c+9 -90 replies
9/26power: use separate Rx and Tx queue limitslib/power/rte_power_pmd_mgmt.c+2 -20 replies
10/26net/af_xdp: use separate Rx and Tx queue limitsdrivers/net/af_xdp/rte_eth_af_xdp.c+1 -10 replies
11/26net/cnxk: use separate Rx and Tx queue limitsdrivers/net/cnxk/cnxk_ethdev_ops.c+2 -20 replies
12/26net/failsafe: use separate Rx and Tx queue limitsdrivers/net/failsafe/failsafe_ops.c+2 -20 replies
13/26net/hns3: use separate Rx and Tx queue limitsdrivers/net/hns3/hns3_tm.c+1 -10 replies
14/26net/mlx5: use separate Rx and Tx queue limitsdrivers/net/mlx5/mlx5_flow.c drivers/net/mlx5/mlx5_flow_hw.c+2 -20 replies
15/26net/null: use separate Rx and Tx queue limitsdrivers/net/null/rte_eth_null.c+2 -20 replies
16/26net/sfc: use separate Rx and Tx queue limitsdrivers/net/sfc/sfc_sw_stats.c+4 -20 replies
17/26net/thunderx: use separate Rx and Tx queue limitsdrivers/net/thunderx/nicvf_ethdev.c+1 -10 replies
18/26net/vhost: use separate Rx and Tx queue limitsdrivers/net/vhost/rte_eth_vhost.c+4 -30 replies
19/26app/dumpcap: use separate Rx and Tx queue limitsapp/dumpcap/main.c+1 -11 reply
20/26app/test-pmd: use separate Rx and Tx queue limitsapp/test-pmd/testpmd.c app/test-pmd/testpmd.h+12 -110 replies
21/26examples/ipsec-secgw: use separate Rx and Tx queue limitsexamples/ipsec-secgw/ipsec-secgw.c examples/ipsec-secgw/ipsec.c+2 -20 replies
22/26examples/l3fwd-power: use separate Rx and Tx queue limitsexamples/l3fwd-power/main.c examples/l3fwd-power/perf_core.c+2 -20 replies
23/26examples/l3fwd: use separate Rx and Tx queue limitsexamples/l3fwd/main.c+1 -10 replies
24/26examples/vhost: use separate Rx and Tx queue limitsexamples/vhost/main.c examples/vhost/main.h+2 -20 replies
25/26config: make queues per port a meson config optionconfig/meson.build config/rte_config.h doc/guides/rel_notes/release_24_11.rst +1 more+17 -50 replies
26/26config: add computed max queues define for compatibilityconfig/meson.build doc/guides/rel_notes/deprecation.rst doc/guides/rel_notes/release_24_11.rst+26 -10 replies

Reviews trailers per patch

All 26 patches have a Reviewed-by or Acked-by.

PatchMorten Brørup
1/26A-b
2/26A-b
3/26A-b
4/26A-b
5/26A-b
6/26A-b
7/26A-b
8/26A-b
9/26A-b
10/26A-b
11/26A-b
12/26A-b
13/26A-b
14/26A-b
15/26A-b
16/26A-b
17/26A-b
18/26A-b
19/26A-b
20/26A-b
21/26A-b
22/26A-b
23/26A-b
24/26A-b
25/26A-b
26/26A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/26] add meson config options for queues per port

There are a number of issues with the current RTE_MAX_QUEUES_PER_PORT setting in DPDK that are addressed by this patchset:

* The name does not make it clear that this is intended as an ethdev-only setting
* A number of other libraries are using this define rather than having more relevant defines for the particular usecase.
* The define is hard-coded in DPDK source code and is not adjustable via a build-time/meson option
* Because of the lack of configurability, the max is therefore set to a conservatively-high value, wasting memory.
* There is an assumption that the number of Rx queues and Tx queues should have the same maximum value. Depending on application, it may be desirable to have fan-in with multiple Rx queues e.g. for classification/filtering, feed a single Tx queue, or the opposite where, e.g. for QoS Tx scheduling, a few Rx queues feeds a very large number of Tx queues.

This patchset therefore addresses these by:

* replacing the single define for max queues with independent defines for Rx and Tx queues.
* adjusts the name to ensure that it is clear the defines are for ethports only. [ethports being used in the RTE_MAX_ETHPORTS setting].
* replaces occurances of RTE_MAX_QUEUES_PER_PORT with appropriate defines for non-ethdev use cases
* replaces all other internal occurances of the define with the new per-Rx and per-Tx definitions.
* adds meson config options to allow build-time configuration of the max Rx and Tx queue values.

Naming Note:
* The new meson config options are called "max_ethport_rx_queues" and "max_ethport_tx_queues" so that in the meson options list they appear alphabetically beside the existing "max_ethports" option.
* For naming consistency, the new C defines are therefore RTE_MAX_ETHPORT_RX_QUEUES and RTE_MAX_ETHPORT_TX_QUEUES.

V3:
* Resend of v2 with correct author email, to avoid reply bounces
* drop "rfc" prefix from patches

V2:
* What was a single patch with "3 insertions(+), 1 deletion(-)" has now become a 26-patch set! :-)
* Created separate Rx and Tx defines
* Ensured that the name makes it clear that the define is for ethdev
* When updating internal use, created one patch per component for easier maintainer review. In most cases it was obvious whether Rx or Tx define should be used, but a few cases were less clear.
* Added documentation updates for the changes (release notes and deprecation notice), spread across 3 of the patches.

Bruce Richardson (26):
cryptodev: remove use of ethdev max queues definition
eventdev: remove use of ethev queues define app/test-bbdev: remove use of ethdev queue count value
config: add separate defines for max Rx and Tx queues
ethdev: use separate Rx and Tx queue limits
bpf: use separate Rx and Tx queue limits
latencystats: use separate Rx and Tx queue limits
pdump: use separate Rx and Tx queue limits
power: use separate Rx and Tx queue limits net/af_xdp: use separate Rx and Tx queue limits net/cnxk: use separate Rx and Tx queue limits net/failsafe: use separate Rx and Tx queue limits net/hns3: use separate Rx and Tx queue limits net/mlx5: use separate Rx and Tx queue limits net/null: use separate Rx and Tx queue limits net/sfc: use separate Rx and Tx queue limits net/thunderx: use separate Rx and Tx queue limits net/vhost: use separate Rx and Tx queue limits app/dumpcap: use separate Rx and Tx queue limits app/test-pmd: use separate Rx and Tx queue limits examples/ipsec-secgw: use separate Rx and Tx queue limits examples/l3fwd-power: use separate Rx and Tx queue limits examples/l3fwd: use separate Rx and Tx queue limits examples/vhost: use separate Rx and Tx queue limits
config: make queues per port a meson config option
config: add computed max queues define for compatibility

 app/dumpcap/main.c                     |  2 +-
 app/test-bbdev/test_bbdev.c            |  4 ++--
 app/test-pmd/testpmd.c                 |  7 ++++---
 app/test-pmd/testpmd.h                 | 16 ++++++++--------
 config/meson.build                     | 10 ++++++++++
 config/rte_config.h                    |  2 +-
 doc/guides/rel_notes/deprecation.rst   | 11 +++++++++++
 doc/guides/rel_notes/release_24_11.rst | 21 +++++++++++++++++++++
 drivers/net/af_xdp/rte_eth_af_xdp.c    |  2 +-
 drivers/net/cnxk/cnxk_ethdev_ops.c     |  4 ++--
 drivers/net/failsafe/failsafe_ops.c    |  4 ++--
 drivers/net/hns3/hns3_tm.c             |  2 +-
 drivers/net/mlx5/mlx5_flow.c           |  2 +-
 drivers/net/mlx5/mlx5_flow_hw.c        |  2 +-
 drivers/net/null/rte_eth_null.c        |  4 ++--
 drivers/net/sfc/sfc_sw_stats.c         |  6 ++++--
 drivers/net/thunderx/nicvf_ethdev.c    |  2 +-
 drivers/net/vhost/rte_eth_vhost.c      |  7 ++++---
 examples/ipsec-secgw/ipsec-secgw.c     |  2 +-
 examples/ipsec-secgw/ipsec.c           |  2 +-
 examples/l3fwd-power/main.c            |  2 +-
 examples/l3fwd-power/perf_core.c       |  2 +-
 examples/l3fwd/main.c                  |  2 +-
 examples/vhost/main.c                  |  2 +-
 examples/vhost/main.h                  |  2 +-
 lib/bpf/bpf_pkt.c                      |  3 ++-
 lib/cryptodev/cryptodev_pmd.c          |  4 ++--
 lib/ethdev/ethdev_driver.h             |  8 ++++----
 lib/ethdev/ethdev_private.c            | 24 ++++++++++++++----------
 lib/ethdev/rte_ethdev.c                | 16 +++++++---------
 lib/ethdev/rte_ethdev.h                | 18 +++++++++---------
 lib/eventdev/eventdev_private.c        |  2 +-
 lib/latencystats/rte_latencystats.c    |  4 ++--
 lib/pdump/rte_pdump.c                  | 18 +++++++++---------
 lib/power/rte_power_pmd_mgmt.c         |  4 ++--
 meson_options.txt                      |  4 ++++
 36 files changed, 140 insertions(+), 87 deletions(-)

--
2.43.0