Skip to content

clk: Unit test clk unregistration paths

Stephen Boyd linux-clk linux-patches lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12clk: Fix clk not being unlinked from consumers listdrivers/clk/clk.c+2 -00 replies
2/12clk: test: Introduce clk_hw_unregister_kunit()drivers/clk/clk_kunit_helpers.c include/kunit/clk.h+26 -00 replies
3/12clk: test: Introduce clk_put_kunit()drivers/clk/clk_kunit_helpers.c include/kunit/clk.h+22 -00 replies
4/12clk: Add tests for unregistering clk_hw and using consumer APIsdrivers/clk/clk_test.c+298 -00 replies
5/12clk: Fail phase APIs after clk_hw is unregistereddrivers/clk/clk.c+10 -30 replies
6/12clk: Test clk_get_phase() behavior after clk_hw is unregistereddrivers/clk/clk_test.c+62 -00 replies
7/12clk: Fail duty cycle APIs after clk_hw is unregistereddrivers/clk/clk.c+6 -00 replies
8/12clk: Test clk_set_duty_cycle() behavior after clk_hw is unregistereddrivers/clk/clk_test.c+70 -00 replies
9/12clk: Prevent unregistered clk_hw from being reinserted into clk treedrivers/clk/clk.c+5 -00 replies
10/12clk: Test clk_set_parent() behavior after clk_hw is unregistereddrivers/clk/clk_test.c+101 -00 replies
11/12clk: Test parent/clk flags combos while unregistering a clk_hwdrivers/clk/clk_test.c+169 -340 replies
12/12WIP: clk: Test behavior of children clks after a parent is unregistereddrivers/clk/clk_test.c+57 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/12] clk: Unit test clk unregistration paths

The clk_hw_unregister() path is rarely used and almost entirely untested. Case in point, the first patch in this series that fixes a bug due to unregistering a clk_hw and calling clk_put(). Add unit tests for this code and test the consumer APIs to make sure the behavior stays consistent.

The last patch is a WIP because I haven't gotten around to fixing all the problems.

Cc Brendan Higgins <[email protected]>
Cc David Gow <[email protected]>
Cc Rae Moar <[email protected]>

Nuno Sá (1):
clk: Fix clk not being unlinked from consumers list

Stephen Boyd (11):
clk: test: Introduce clk_hw_unregister_kunit()
clk: test: Introduce clk_put_kunit()
clk: Add tests for unregistering clk_hw and using consumer APIs
clk: Fail phase APIs after clk_hw is unregistered
clk: Test clk_get_phase() behavior after clk_hw is unregistered
clk: Fail duty cycle APIs after clk_hw is unregistered
clk: Test clk_set_duty_cycle() behavior after clk_hw is unregistered
clk: Prevent unregistered clk_hw from being reinserted into clk tree
clk: Test clk_set_parent() behavior after clk_hw is unregistered
clk: Test parent/clk flags combos while unregistering a clk_hw
WIP: clk: Test behavior of children clks after a parent is
unregistered

 drivers/clk/clk.c               |  26 +-
 drivers/clk/clk_kunit_helpers.c |  46 ++
 drivers/clk/clk_test.c          | 720 ++++++++++++++++++++++++++++++++
 include/kunit/clk.h             |   2 +
 4 files changed, 791 insertions(+), 3 deletions(-)

base-commit: 274aff8711b2e77c27bbda0ddc24caa39f154bfa

Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git