usb: typec: ucsi: Minor improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 9 repliesIn review
- v15 patches 3 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | usb: typec: ucsi: Remove unused fields from struct ucsi_connector_statusdrivers/ | +2 | 7 replies | |
| 2/6 | usb: typec: ucsi: Don't truncate the readsdrivers/ drivers/ | +4 | 1 reply | |
| 3/6 | usb: typec: ucsi: Only assign the identity structure if the PPM supports itdrivers/ | +4 | 1 reply | |
| 4/6 | usb: typec: ucsi: Common function for the GET_PD_MESSAGE commanddrivers/ drivers/ | +27 | 0 replies | |
| 5/6 | usb: typec: ucsi: Call CANCEL from single locationdrivers/ | +4 | 0 replies | |
| 6/6 | usb: typec: ucsi: Remove useless error check from ucsi_read_error()drivers/ | +0 | 0 replies |
Reviews trailers per patch
2 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Abhishek Pandit-Subedi |
|---|---|
| 1/6 | |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/6] usb: typec: ucsi: Minor improvements
Hi,
The first three patches remove potential problems. I prepared especially the second one as a protection against similar issues that I had to fix earlier. The rest is just cleanups.
What changed since v1:
In this version I refactored the code so that UCSI_MAX_DATA_LENGTH() is introduced in the first patch where it is used.
I also added one more patch, the first one, where I remove the unused fields from struct ucsi_connector_status. Those fields are beyond the MAX_DATA_LENGTH (16 bytes) with the older UCSI versions, so without removing them, the code would fail on older systems after the read truncation is removed in the second patch. Thanks for reporting that Siva.
So please test these if you have time.
The first version of these patches:
https://lore.kernel.org/linux-usb/[email protected]/
thanks,
Heikki Krogerus (6):
usb: typec: ucsi: Remove unused fields from struct
ucsi_connector_status
usb: typec: ucsi: Don't truncate the reads
usb: typec: ucsi: Only assign the identity structure if the PPM
supports it
usb: typec: ucsi: Common function for the GET_PD_MESSAGE command
usb: typec: ucsi: Call CANCEL from single location
usb: typec: ucsi: Remove useless error check from ucsi_read_error()
drivers/usb/typec/ucsi/ucsi.c | 126 ++++++++++------------------------ drivers/usb/typec/ucsi/ucsi.h | 41 ++--------- 2 files changed, 41 insertions(+), 126 deletions(-)
Signature · 1 line
2.43.0