Skip to content

perf inject improvements

Ian Rogers linux-perf-users lkml 2 versions – Applied

Status from this message: Thanks, applied to perf-tools-next,

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyApplied
  2. v113 patches 6 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4perf inject: Fix build ID injectiontools/perf/builtin-inject.c tools/perf/util/build-id.c tools/perf/util/synthetic-events.c +1 more+175 -550 replies
2/4perf inject: Add new mmap2-buildid-all optiontools/perf/builtin-inject.c tools/perf/tests/shell/pipe_test.sh tools/perf/util/synthetic-events.c +1 more+154 -30 replies
3/4perf inject: Lazy build-id mmap2 event insertiontools/perf/builtin-inject.c tools/perf/tests/shell/pipe_test.sh tools/perf/util/map.c +1 more+63 -120 replies
4/4perf callchain: Allow symbols to be optional when resolving a callchaintools/perf/builtin-inject.c tools/perf/util/callchain.c tools/perf/util/callchain.h +2 more+85 -520 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchNamhyung Kim
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] perf inject improvements

Fix the existing build id injection by adding sample IDs on to the synthesized events. This correctly orders the events and addresses issues such as a profiled executable being replaced during its execution.

Add a new --mmap2-buildid-all option that rewrites all mmap events as mmap2 events containing build IDs. This removes the need for build_id events.

Add a new -B option that like --mmap2-buildid-all synthesizes mmap2 with build id events. With -B the behavior is to do it lazily, so only when a sample references the particular map. With system wide profiling that synthesizes mmap events for all running processes the perf.data file savings can be greater than 50%.

Reduce the memory footprint of perf inject by avoiding creating symbols in the callchain, the symbols aren't used during perf inject and necessitate the loading of dsos.

v2: Rename dso__inject* functions to tool__inject* addressing feedback
from Arnaldo and a suggestion from Namhyung that the name should reflect the first argument's type. Rebase, in particular over the perf inject pipe mode fixes. Add Namhyung's acked-by.

Ian Rogers (4):
perf inject: Fix build ID injection
perf inject: Add new mmap2-buildid-all option
perf inject: Lazy build-id mmap2 event insertion perf callchain: Allow symbols to be optional when resolving a
callchain

 tools/perf/builtin-inject.c         | 304 +++++++++++++++++++++++-----
 tools/perf/tests/shell/pipe_test.sh |   2 +
 tools/perf/util/build-id.c          |   6 +-
 tools/perf/util/callchain.c         |   8 +-
 tools/perf/util/callchain.h         |   2 +-
 tools/perf/util/machine.c           |  92 +++++----
 tools/perf/util/machine.h           |  33 ++-
 tools/perf/util/map.c               |   1 +
 tools/perf/util/map.h               |  11 +
 tools/perf/util/synthetic-events.c  | 101 +++++++--
 tools/perf/util/synthetic-events.h  |  21 +-
 11 files changed, 468 insertions(+), 113 deletions(-)
Signature · 1 line
2.46.0.598.g6f2099f65c-goog