Skip to content

Remove support for platform data from samsung keypad

Dmitry Torokhov linux-arm-kernel linux-devicetree linux-input linux-samsung-soc lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 24 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14Input: samsung-keypad - switch to using devm_clk_get_prepared()drivers/input/keyboard/samsung-keypad.c+4 -182 replies
2/14Input: samsung-keypad - do not set input device's parent explicitlydrivers/input/keyboard/samsung-keypad.c+0 -11 reply
3/14Input: samsung-keypad - do not combine memory allocation checksdrivers/input/keyboard/samsung-keypad.c+4 -11 reply
4/14Input: samsung-keypad - use struct_size() helperdrivers/input/keyboard/samsung-keypad.c+3 -31 reply
5/14Input: samsung-keypad - use devm to disable runtime PMdrivers/input/keyboard/samsung-keypad.c+13 -112 replies
6/14Input: samsung-keypad - use guard notation to acquire mutexdrivers/input/keyboard/samsung-keypad.c+2 -66 replies
7/14Input: samsung-keypad - use per-chip parametersdrivers/input/keyboard/samsung-keypad.c+37 -241 reply
8/14Input: samsung-keypad - use BIT() and GENMASK() where appropriatedrivers/input/keyboard/samsung-keypad.c+10 -90 replies
9/14dt-bindings: input: samsung,s3c6410-keypad: introduce compact bindingDocumentation/devicetree/bindings/input/samsung,s3c6410-keypad.yaml+54 -34 replies
10/14Input: samsung-keypad - handle compact bindingdrivers/input/keyboard/samsung-keypad.c+64 -580 replies
11/14ARM: s3c: crag6410: switch keypad device to software propertiesarch/arm/mach-s3c/Kconfig arch/arm/mach-s3c/Kconfig.s3c64xx arch/arm/mach-s3c/Makefile.s3c64xx +5 more+42 -961 reply
12/14Input: samsung-keypad - remove support for platform datadrivers/input/keyboard/samsung-keypad.c include/linux/input/samsung-keypad.h+70 -1590 replies
13/14ARM: s3c: crag6410: use software nodes/properties to set up GPIO keysarch/arm/mach-s3c/gpio-samsung-s3c64xx.h arch/arm/mach-s3c/gpio-samsung.c arch/arm/mach-s3c/mach-crag6410.c+99 -211 reply
14/14ARM: s3c: crag6410 - convert GPIO lookup tables to property entriesarch/arm/mach-s3c/devs.c arch/arm/mach-s3c/devs.h arch/arm/mach-s3c/mach-crag6410.c+67 -771 reply

Reviews trailers per patch

8 of 14 patches have a Reviewed-by or Acked-by.

PatchKrzysztof Kozlowski
1/14
2/14R-b
3/14R-b
4/14R-b
5/14
6/14R-b
7/14R-b
8/14
9/14
10/14
11/14A-b
12/14
13/14A-b
14/14A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/14] Remove support for platform data from samsung keypad

Hi,

This series attempts to rework samsumg=keypad driver to stop using platform data and instead rely on generic device properties only.

The first 8 patches are general cleanup/facelift patches.

The 9th patch introduces alternative binding that is more compact that the original one, which makes it more suitable for use in legacy (non DT) boards with static device properties. Note that the "new" binding is the standard binding for matrix keypads.

Patch #10 implements the new binding in the driver, #11 converts the only user of platform data in the mainline tree to the static device properties, and #12 drops support for platform data from the driver.

Patches #13 and #14 are "bonus" converting the rest of crag6410 to use software nodes/properties to describe GPIO keys, LEDs and other peripherals. Note that I believe they fix and issue with recent conversion to GPIO lookup tables - the names of gpiochip structures I think are "GP<N>" ("GPK", "GPL", etc) and not "GPIO<N>".

Mark, you said you are using this board, it would be great if you could give this a spin.

Thanks!

Dmitry Torokhov (14):
Input: samsung-keypad - switch to using devm_clk_get_prepared()
Input: samsung-keypad - do not set input device's parent explicitly
Input: samsung-keypad - do not combine memory allocation checks
Input: samsung-keypad - use struct_size() helper
Input: samsung-keypad - use devm to disable runtime PM
Input: samsung-keypad - use guard notation to acquire mutex
Input: samsung-keypad - use per-chip parameters
Input: samsung-keypad - use BIT() and GENMASK() where appropriate
dt-bindings: input: samsung,s3c6410-keypad: introduce compact binding
Input: samsung-keypad - handle compact binding
ARM: s3c: crag6410: switch keypad device to software properties
Input: samsung-keypad - remove support for platform data
ARM: s3c: crag6410: use software nodes/properties to set up GPIO keys
ARM: s3c: crag6410 - convert GPIO lookup tables to property entries

 .../input/samsung,s3c6410-keypad.yaml         |  57 +++-
 arch/arm/mach-s3c/Kconfig                     |   5 -
 arch/arm/mach-s3c/Kconfig.s3c64xx             |   1 -
 arch/arm/mach-s3c/Makefile.s3c64xx            |   1 -
 arch/arm/mach-s3c/devs.c                      |  62 ----
 arch/arm/mach-s3c/devs.h                      |   2 -
 arch/arm/mach-s3c/gpio-samsung-s3c64xx.h      |   5 +
 arch/arm/mach-s3c/gpio-samsung.c              |  35 ++
 arch/arm/mach-s3c/keypad.h                    |  27 --
 arch/arm/mach-s3c/mach-crag6410.c             | 242 ++++++++-----
 arch/arm/mach-s3c/setup-keypad-s3c64xx.c      |  20 --
 drivers/input/keyboard/samsung-keypad.c       | 318 ++++++++----------
 include/linux/input/samsung-keypad.h          |  39 ---
 13 files changed, 398 insertions(+), 416 deletions(-)
 delete mode 100644 arch/arm/mach-s3c/keypad.h
 delete mode 100644 arch/arm/mach-s3c/setup-keypad-s3c64xx.c
 delete mode 100644 include/linux/input/samsung-keypad.h
Signature · 1 line
Dmitry