Skip to content

fuse: writeback clean up / refactoring

Joanne Koong linux-fsdevel 4 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 4 repliesApplied
  2. v39 patches 6 repliesSuperseded
  3. v29 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches8 repliesSuperseded

Changes in v4 from the cover letter

* Merge v3's 4/9 and 5/9 into 1 patch (Josef)
* Merge v3's 7/9 and 9/9 into 1 patch

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/7fuse: drop unused fuse_mount arg in fuse_writepage_finish()fs/fuse/file.c+3 -40 replies
2/7fuse: refactor finished writeback stats updates into helper functionfs/fuse/file.c+13 -110 replies
3/7fuse: update stats for pages in dropped aux writeback listfs/fuse/file.c+2 -10 replies
4/7fuse: move initialization of fuse_file to fuse_writepages() instead of in callbackfs/fuse/file.c+6 -120 replies
5/7fuse: convert fuse_writepages_fill() to use a folio for its tmp pagefs/fuse/file.c+7 -70 replies
6/7fuse: move fuse file initialization to wpa allocation timefs/fuse/file.c+2 -40 replies
7/7fuse: refactor out shared logic in fuse_writepages_fill() and fuse_writepage_locked()fs/fuse/file.c+57 -460 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJingbo XuJosef Bacik
SeriesR-b R-b
1/7R-b
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/7] fuse: writeback clean up / refactoring

This patchset contains some minor clean up / refactoring for the fuse writeback code.

As a sanity check, I ran fio to check against crashes - ./libfuse/build/example/passthrough_ll -o cache=always -o writeback -o source=~/fstests ~/tmp_mount
fio --name=test --ioengine=psync --iodepth=1 --rw=randwrite --bs=1M --direct=0 --size=2G --numjobs=2 --directory=/home/user/tmp_mount

and (suggested by Miklos) fsx test -
sudo HOST_OPTIONS=fuse.config ./check -fuse generic/616 generic/616 (soak buffered fsx test) without the -U (io_uring) flag (verified this uses the fuse_writepages_fill path)

v3:
https://lore.kernel.org/linux-fsdevel/[email protected]/
Changes from v3 -> v4:
* Merge v3's 4/9 and 5/9 into 1 patch (Josef)
* Merge v3's 7/9 and 9/9 into 1 patch

v2:
https://lore.kernel.org/linux-fsdevel/[email protected]/
Changes from v2 -> v3:
* Drop v2 9/9 (Miklos)
* Split v2 8/9 into 2 patches (v3 8/9 and 9/9) to make review easier
* Change error pattern usage (Miklos)

v1:
https://lore.kernel.org/linux-fsdevel/[email protected]/
Changes from v1 -> v2:
* Added patches 2 and 4-9
* Add commit message to patch 1 (Jingbo)

Joanne Koong (7):
fuse: drop unused fuse_mount arg in fuse_writepage_finish()
fuse: refactor finished writeback stats updates into helper function
fuse: update stats for pages in dropped aux writeback list
fuse: move initialization of fuse_file to fuse_writepages() instead of
in callback
fuse: convert fuse_writepages_fill() to use a folio for its tmp page
fuse: move fuse file initialization to wpa allocation time
fuse: refactor out shared logic in fuse_writepages_fill() and
fuse_writepage_locked()

 fs/fuse/file.c | 167 +++++++++++++++++++++++++------------------------
 1 file changed, 86 insertions(+), 81 deletions(-)
Signature · 1 line
2.43.5