Skip to content

inode: turn i_state into u32

Christian Brauner linux-fsdevel 3 versions – In review

Get series with b4
b4 am [email protected] change-id 20240820-work-i_state-4e34db39bcf8

Versions newest first

  1. v3 Latest6 patches 7 repliesIn review
  2. v2 RFC6 patches 28 repliesSuperseded
  3. v1 RFC5 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Use manual barrier.
- Link to v2: https://lore.kernel.org/r/[email protected]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6fs: add i_state helpersfs/inode.c include/linux/fs.h+26 -01 reply
2/6fs: reorder i_state bitsinclude/linux/fs.h+21 -171 reply
3/6inode: port __I_SYNC to var eventfs/fs-writeback.c+29 -161 reply
4/6inode: port __I_NEW to var eventfs/bcachefs/fs.c fs/dcache.c fs/inode.c +1 more+38 -141 reply
5/6inode: port __I_LRU_ISOLATING to var eventfs/inode.c+19 -81 reply
6/6inode: make i_state a u32include/linux/fs.h+2 -11 reply

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJosef BacikJan Kara
SeriesR-b
1/6R-b
2/6R-b
3/6R-b
4/6
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] inode: turn i_state into u32

Hey,

This is v3. I changed to manual barriers as requested and commented them.

---

I've recently looked for some free space in struct inode again because of some exec kerfuffle we recently had and while my idea didn't turn into anything I noticed that we often waste bytes when using wait bit operations. So I set out to switch that to another mechanism that would allow us to free up bytes. So this is an attempt to turn i_state from an unsigned long into an u32 using the individual bytes of i_state as addresses for the wait var event mechanism (Thanks to Linus for that idea.).

This survives LTP, xfstests on various filesystems, and will-it-scale.

To: Linus Torvalds <[email protected]>

Cc NeilBrown <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Jeff Layton <[email protected]>
Cc Jan Kara <[email protected]>
Cc Christian Brauner <[email protected]>

---
Changes in v3:
- Use manual barrier.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Actually send out the correct branch.
- Link to v1: https://lore.kernel.org/r/[email protected]

---

---
base-commit: 01e603fb789c75b3a0c63bddd42a42a710da7a52
change-id: 20240820-work-i_state-4e34db39bcf8