Skip to content

Fixes for IPsec over bonding

Jianbo Liu netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 1 replyApplied 3/3
  2. v53 patches 8 repliesSuperseded

V5 from the cover letter

- Rebased.
- Removed state deletion/free in bond_ipsec_add_sa_all() added before, as real_dev is not set to NULL in Nikolay's patch.

Patches in v6 All 3 applied

#Subject and filesSizeRepliesApplied
1/3bonding: implement xdo_dev_state_free and call it after deletiondrivers/net/bonding/bond_main.c+36 -00 repliesApplied
2/3bonding: extract the use of real_device into local variabledrivers/net/bonding/bond_main.c+33 -250 repliesApplied
3/3bonding: change ipsec_lock from spin lock to mutexdrivers/net/bonding/bond_main.c include/net/bonding.h+44 -370 repliesApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHangbin LiuCosmin RatiuJay Vosburgh
SeriesA-b
1/3R-b
2/3R-b R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH net V6 0/3] Fixes for IPsec over bonding

Hi,

This patchset provides bug fixes for IPsec over bonding driver.

It adds the missing xdo_dev_state_free API, and fixes "scheduling while atomic" by using mutex lock instead.

Series generated against:
commit c07ff8592d57 ("netem: fix return value if duplicate enqueue fails")

Thanks!
Jianbo

V6
- Add netdev_hold/netdev_put to prevent real_dev from being freed for bond_ipsec_add_sa, bond_ipsec_del_sa and bond_ipsec_free_sa.

V5:
- Rebased.
- Removed state deletion/free in bond_ipsec_add_sa_all() added before, as real_dev is not set to NULL in Nikolay's patch.

V4:
- Add to all patches: Reviewed-by: Hangbin Liu <[email protected]>.
- Update commit message in patch 1 (Jakub).

V3:
- Add RCU read lock/unlock for bond_ipsec_add_sa, bond_ipsec_del_sa and bond_ipsec_free_sa.

V2:
- Rebased on top of latest net branch.
- Squashed patch #2 into #1 per Hangbin comment.
- Addressed Hangbin's comments.
- Patch #3 (was #4): Addressed comments by Paolo.

Jianbo Liu (3):
bonding: implement xdo_dev_state_free and call it after deletion
bonding: extract the use of real_device into local variable
bonding: change ipsec_lock from spin lock to mutex

 drivers/net/bonding/bond_main.c | 159 +++++++++++++++++++++-----------
 include/net/bonding.h           |   2 +-
 2 files changed, 106 insertions(+), 55 deletions(-)
Signature · 1 line
2.21.0