Skip to content

platform/x86: int3472: A few cleanups

Andy Shevchenko lkml oe-kbuild oe-kbuild-all platform-driver-x86 2 versions – NAK

Status from this message: NAK

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 16 repliesNAK
  2. v14 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- amended code example in the documentation (Ilpo, Greg)
- added note about -ENOMEM and 0 to the kernel-doc
- fixed kernel-doc warning (no "Return" section)
- added tags (Ilpo)

Patches in v2

#Subject and filesSizeRepliesApplied
1/4driver core: Ignore 0 in dev_err_probe()drivers/base/core.c+11 -210 replies
2/4platform/x86: int3472: Simplify dev_err_probe() usagedrivers/platform/x86/intel/int3472/discrete.c+1 -44 replies
3/4platform/x86: int3472: Use GPIO_LOOKUP() macrodrivers/platform/x86/intel/int3472/discrete.c+1 -50 replies
4/4platform/x86: int3472: Use str_high_low()drivers/platform/x86/intel/int3472/discrete.c+2 -10 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchIlpo JärvinenGreg Kroah-HartmanDan Carpenter
1/4R-b R-b NAKed-by
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/4] platform/x86: int3472: A few cleanups

A few cleanups to the driver. It includes an amendment to dev_err_probe() to ignore 0 error code. The patches 1 and 2 are dependent, while patches 2 and 3 may be applied in any order.

Assumed to go via PDx86 tree if no objections to the code.

v2:
- amended code example in the documentation (Ilpo, Greg)
- added note about -ENOMEM and 0 to the kernel-doc
- fixed kernel-doc warning (no "Return" section)
- added tags (Ilpo)

Andy Shevchenko (4):
driver core: Ignore 0 in dev_err_probe() platform/x86: int3472: Simplify dev_err_probe() usage platform/x86: int3472: Use GPIO_LOOKUP() macro platform/x86: int3472: Use str_high_low()

 drivers/base/core.c                           | 13 +++++++++++--
 drivers/platform/x86/intel/int3472/discrete.c | 14 ++++----------
 2 files changed, 15 insertions(+), 12 deletions(-)
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac