Skip to content

perf annotate-data: Update data-type profiling quality (v2)

Namhyung Kim linux-perf-users lkml 1 version Applied

Status from this message: Thanks, applied to perf-tools-next,

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4perf dwarf-aux: Handle bitfield members from pointer accesstools/perf/util/dwarf-aux.c+9 -20 replies
2/4perf annotate-data: Update debug messagestools/perf/util/annotate-data.c+35 -100 replies
3/4perf annotate-data: Update stack slot for the storetools/perf/util/annotate-data.c+25 -40 replies
4/4perf annotate-data: Copy back variable types after movetools/perf/arch/x86/annotate/instructions.c tools/perf/util/annotate-data.c tools/perf/util/annotate-data.h+40 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCHSET 0/4] perf annotate-data: Update data-type profiling quality (v2)

Hello,

This is continuation of data type profiling series to improve its quality. I've also found some more bugs and room for improvements.

Acutally it depends on the a couple of fixes I sent out yesterday. But as they will be merged to perf-tools-next, I omitted them here.

There's no dramatic improvements at this moment, but I handled some corner cases which makes instruction tracking more flexible. One change is when it accesses (stores) a stack slot for the first time. As it doesn't save anything there yet, it doesn't come with a type info. In that case it can try to process the instruction with update_insn_state() and get the type information again.

Another update is when compiler generates the debug info inaccurately. A variable information is there but in some cases it was using another register to access the data and it resulted in no type information. So I tracked the (direct) register move and update the type info for the source registre as well.

The code is available at 'perf/data-profile-update-v2' branch in

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung

Namhyung Kim (4):
perf dwarf-aux: Handle bitfield members from pointer access perf annotate-data: Update debug messages
perf annotate-data: Update stack slot for the store perf annotate-data: Copy back variable types after move

 tools/perf/arch/x86/annotate/instructions.c |   8 ++
 tools/perf/util/annotate-data.c             | 105 +++++++++++++++++---
 tools/perf/util/annotate-data.h             |   1 +
 tools/perf/util/dwarf-aux.c                 |  11 +-
 4 files changed, 109 insertions(+), 16 deletions(-)
Signature · 1 line
2.46.0.184.g6999bdac58-goog