Skip to content

fstests/fsx: test coverage for eof zeroing

Brian Foster fstests linux-xfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 6 repliesIn review
  2. v13 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Factored out patch 1 to fix simulation mode.
- Use MAP_FAILED, don't inject data for simulated ops.
- Rebase to latest master and renumber test.
- Use run_fsx and -S 0 by default (timestamp seed).
v1: https://lore.kernel.org/fstests/[email protected]/

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4fsx: don't skip file size and buf updates on simulated opsltp/fsx.c+21 -192 replies
2/4fsx: factor out a file size update helperltp/fsx.c+21 -281 reply
3/4fsx: support eof page pollution for eof zeroing test coverageltp/fsx.c+77 -21 reply
4/4generic: test to run fsx eof pollutiontests/generic/363 tests/generic/363.out+25 -01 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDarrick J. Wong
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] fstests/fsx: test coverage for eof zeroing

Hi all,

Here's v2 of the patches for improved test coverage (via fsx) for EOF related zeroing. The most notable change is that the discussion on v1 uncovered that some of the existing fsx behavior was wrong wrt to simulated ops, so patch 1 is factored out as a standalone bug fix to address that.

Brian

v2:
- Factored out patch 1 to fix simulation mode.
- Use MAP_FAILED, don't inject data for simulated ops.
- Rebase to latest master and renumber test.
- Use run_fsx and -S 0 by default (timestamp seed).
v1: https://lore.kernel.org/fstests/[email protected]/

Brian Foster (4):
fsx: don't skip file size and buf updates on simulated ops
fsx: factor out a file size update helper
fsx: support eof page pollution for eof zeroing test coverage
generic: test to run fsx eof pollution

 ltp/fsx.c             | 134 ++++++++++++++++++++++++++++++++----------
 tests/generic/363     |  23 ++++++++
 tests/generic/363.out |   2 +
 3 files changed, 127 insertions(+), 32 deletions(-)
 create mode 100755 tests/generic/363
 create mode 100644 tests/generic/363.out
Signature · 1 line
2.45.0