Skip to content

iomap: flush dirty cache over unwritten mappings on zero range

Brian Foster linux-fsdevel linux-xfs 3 versions – Applied

Status from this message: Applied to the vfs.blocksize branch of the vfs/vfs.git tree.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyApplied
  2. v22 patches 10 repliesSuperseded
  3. v12 patches 9 repliesSuperseded

Changes in v3 from the cover letter

- Rework comment(s) in patch 2 to explain marking the mapping stale.
- Added R-b tags.
v2: https://lore.kernel.org/linux-fsdevel/[email protected]/
- Update comment in patch 2 to explain hole case.
v1: https://lore.kernel.org/linux-fsdevel/[email protected]/
- Alternative approach, flush instead of revalidate.
rfc: https://lore.kernel.org/linux-fsdevel/[email protected]/

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2iomap: fix handling of dirty folios over unwritten extentsfs/iomap/buffered-io.c fs/xfs/xfs_iops.c+10 -100 replies
2/2iomap: make zero range flush conditional on unwritten mappingsfs/iomap/buffered-io.c+54 -90 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDarrick J. WongJosef Bacik
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] iomap: flush dirty cache over unwritten mappings on zero range

Hi all,

Here's v3 of the iomap zero range flush fixes. No real changes here other than comment updates to better explain the flush and stale logic. The latest version of corresponding test support is posted here [1]. Thoughts, reviews, flames appreciated.

v3:
- Rework comment(s) in patch 2 to explain marking the mapping stale.
- Added R-b tags.
v2: https://lore.kernel.org/linux-fsdevel/[email protected]/
- Update comment in patch 2 to explain hole case.
v1: https://lore.kernel.org/linux-fsdevel/[email protected]/
- Alternative approach, flush instead of revalidate.
rfc: https://lore.kernel.org/linux-fsdevel/[email protected]/

Brian Foster (2):
iomap: fix handling of dirty folios over unwritten extents
iomap: make zero range flush conditional on unwritten mappings

 fs/iomap/buffered-io.c | 63 +++++++++++++++++++++++++++++++++++++++---
 fs/xfs/xfs_iops.c      | 10 -------
 2 files changed, 59 insertions(+), 14 deletions(-)
Signature · 1 line
2.45.0