follow up for __jited test tag
Status from this message: This series was applied to bpf/bpf-next.git (master)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 3 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | selftests/bpf: test_loader.c:get_current_arch() should not return 0tools/ | +5 | 0 replies | Applied |
| 2/3 | selftests/bpf: match both retq/rethunk in verifier_tailcall_jittools/ | +2 | 0 replies | Applied |
| 3/3 | selftests/bpf: #define LOCAL_LABEL_LEN for jit_disasm_helpers.ctools/ | +14 | 0 replies | Applied |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH bpf-next 0/3] follow up for __jited test tag
This patch-set is a collection of follow-ups for "__jited test tag to check disassembly after jit" series (see [1]).
First patch is most important:
as it turns out, I broke all test_loader based tests for s390 CI. E.g. see log [2] for s390 execution of test_progs,
note all 'verivier_*' tests being skipped.
This happens because of incorrect handling of corner case when get_current_arch() does not know which architecture to return.
Second patch makes matching of function return sequence in verifier_tailcall_jit more flexible:
-__jited(" retq")
+__jited(" {{(retq|jmp 0x)}}")The difference could be seen with and w/o mitigations=off boot parameter for test VM (CI runs with mitigations=off, hence it generates retq).
Third patch addresses Alexei's request to add #define and a comment in jit_disasm_helpers.c.
[1] https://lore.kernel.org/bpf/[email protected]/
[2] https://github.com/kernel-patches/bpf/actions/runs/10518445973/job/29144511595
Eduard Zingerman (3):
selftests/bpf: test_loader.c:get_current_arch() should not return 0 selftests/bpf: match both retq/rethunk in verifier_tailcall_jit selftests/bpf: #define LOCAL_LABEL_LEN for jit_disasm_helpers.c
.../testing/selftests/bpf/jit_disasm_helpers.c | 17 ++++++++++++++--- .../selftests/bpf/progs/verifier_tailcall_jit.c | 4 ++-- tools/testing/selftests/bpf/test_loader.c | 9 +++++---- 3 files changed, 21 insertions(+), 9 deletions(-)
Signature · 1 line
2.46.0