Skip to content

netfs, cifs: Further fixes

David Howells ceph-devel linux-cifs linux-erofs linux-fsdevel linux-mm linux-nfs lkml netfs v9fs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5cifs: Fix FALLOC_FL_PUNCH_HOLE supportfs/smb/client/smb2ops.c+24 -00 replies
2/5netfs, cifs: Improve some debugging bitsfs/netfs/io.c fs/smb/client/smb2ops.c+6 -40 replies
3/5netfs: Fix missing iterator reset on retry of short readfs/netfs/io.c+1 -00 replies
4/5cifs: Fix short read handlingfs/smb/client/smb2pdu.c+2 -100 replies
5/5cifs: Fix credit handlingfs/smb/client/file.c fs/smb/client/smb2ops.c fs/smb/client/trace.h+11 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] netfs, cifs: Further fixes

Hi Christian, Steve,

Here are some more fixes to cifs and one to netfs:

(1) Fix cifs FALLOC_FL_PUNCH_HOLE support as best I can. If it's going to punch a hole in dirty data in the pagecacne, invalidating that data may result in the EOF not being moved correctly. The set-zero and the eof-move RPC ops really need compounding to avoid third-party interference.

(2) Adjust three debugging output statements. Not strictly a fix, so could be dropped. Including the subreq ID in some extra debug lines helps a bit, though.

(3) Fix netfslib's short read retry to reset the buffer iterator otherwise the wrong part of the buffer may get written on.

(4) Further fix the early EOF detection in cifs read.

(5) Further fixes for cifs credit handling.

The patches can also be found here:

https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes

Thanks,
David

David Howells (5):
cifs: Fix FALLOC_FL_PUNCH_HOLE support
netfs, cifs: Improve some debugging bits
netfs: Fix missing iterator reset on retry of short read
cifs: Fix short read handling
cifs: Fix credit handling

 fs/netfs/io.c           |  3 ++-
 fs/smb/client/file.c    |  9 +++++++++
 fs/smb/client/smb2ops.c | 34 ++++++++++++++++++++++++++++++----
 fs/smb/client/smb2pdu.c | 12 ++----------
 fs/smb/client/trace.h   |  1 +
 5 files changed, 44 insertions(+), 15 deletions(-)