Skip to content

Convert keyboard drivers to use new cleanup facilities

Dmitry Torokhov imx linux-arm-kernel linux-input linux-tegra lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17Input: adp5589-keys - use guard notation when acquiring mutexdrivers/input/keyboard/adp5589-keys.c+18 -210 replies
2/17Input: applespi - use guard notation when acquiring spinlockdrivers/input/keyboard/applespi.c+18 -540 replies
3/17Input: atkbd - use guard notation when acquiring mutexdrivers/input/keyboard/atkbd.c+15 -221 reply
4/17Input: ep93xx_keypad - use guard notation when acquiring mutexdrivers/input/keyboard/ep93xx_keypad.c+2 -60 replies
5/17Input: gpio-keys - switch to using cleanup functionsdrivers/input/keyboard/gpio_keys.c+17 -271 reply
6/17Input: imx_keypad - use guard notation when acquiring mutexdrivers/input/keyboard/imx_keypad.c+11 -160 replies
7/17Input: ipaq-micro-keys - use guard notation when acquiring mutex and spinlockdrivers/input/keyboard/ipaq-micro-keys.c+5 -70 replies
8/17Input: iqs62x-keys - use cleanup facility for fwnodesdrivers/input/keyboard/iqs62x-keys.c+2 -51 reply
9/17Input: lm8323 - use guard notation when acquiring mutexesdrivers/input/keyboard/lm8323.c+22 -270 replies
10/17Input: lpc32xx-keys - use guard notation when acquiring mutexdrivers/input/keyboard/lpc32xx-keys.c+9 -90 replies
11/17Input: matrix_keypad - use guard notation when acquiring spinlockdrivers/input/keyboard/matrix_keypad.c+8 -100 replies
12/17Input: omap4-keypad - use guard notation when acquiring mutexdrivers/input/keyboard/omap4-keypad.c+1 -30 replies
13/17Input: pmic8xxx-keypad - use guard notation when acquiring mutexdrivers/input/keyboard/pmic8xxx-keypad.c+2 -60 replies
14/17Input: pxa27x_keypad - use guard notation when acquiring mutexdrivers/input/keyboard/pxa27x_keypad.c+8 -80 replies
15/17Input: spear-keyboard - use guard notation when acquiring mutexdrivers/input/keyboard/spear-keyboard.c+2 -60 replies
16/17Input: st-keyscan - use guard notation when acquiring mutexdrivers/input/keyboard/st-keyscan.c+10 -90 replies
17/17Input: tegra-kbc - use guard notation when acquiring mutex and spinlockdrivers/input/keyboard/tegra-kbc.c+19 -261 reply

Reviews trailers per patch

4 of 17 patches have a Reviewed-by or Acked-by.

PatchHans de GoedeJeff LaBundyThierry Reding
1/17
2/17
3/17R-b
4/17
5/17R-b
6/17
7/17
8/17R-b
9/17
10/17
11/17
12/17
13/17
14/17
15/17
16/17
17/17A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/17] Convert keyboard drivers to use new cleanup facilities

Hi,

This series converts drivers found in drivers/input/keyboard to use new __free() and guard() cleanup facilities that simplify the code and ensure that all resources are released appropriately.

Thanks!

Dmitry Torokhov (17):
Input: adp5589-keys - use guard notation when acquiring mutex
Input: applespi - use guard notation when acquiring spinlock
Input: atkbd - use guard notation when acquiring mutex
Input: ep93xx_keypad - use guard notation when acquiring mutex
Input: gpio-keys - switch to using cleanup functions
Input: imx_keypad - use guard notation when acquiring mutex
Input: ipaq-micro-keys - use guard notation when acquiring mutex and spinlock
Input: iqs62x-keys - use cleanup facility for fwnodes
Input: lm8323 - use guard notation when acquiring mutexes
Input: lpc32xx-keys - use guard notation when acquiring mutex
Input: matrix_keypad - use guard notation when acquiring spinlock
Input: omap4-keypad - use guard notation when acquiring mutex
Input: pmic8xxx-keypad - use guard notation when acquiring mutex
Input: pxa27x_keypad - use guard notation when acquiring mutex
Input: spear-keyboard - use guard notation when acquiring mutex
Input: st-keyscan - use guard notation when acquiring mutex
Input: tegra-kbc - use guard notation when acquiring mutex and spinlock

 drivers/input/keyboard/adp5589-keys.c    | 39 ++++++-------
 drivers/input/keyboard/applespi.c        | 72 ++++++------------------
 drivers/input/keyboard/atkbd.c           | 37 +++++-------
 drivers/input/keyboard/ep93xx_keypad.c   |  8 +--
 drivers/input/keyboard/gpio_keys.c       | 44 ++++++---------
 drivers/input/keyboard/imx_keypad.c      | 27 ++++-----
 drivers/input/keyboard/ipaq-micro-keys.c | 12 ++--
 drivers/input/keyboard/iqs62x-keys.c     |  7 +--
 drivers/input/keyboard/lm8323.c          | 49 ++++++++--------
 drivers/input/keyboard/lpc32xx-keys.c    | 18 +++---
 drivers/input/keyboard/matrix_keypad.c   | 18 +++---
 drivers/input/keyboard/omap4-keypad.c    |  4 +-
 drivers/input/keyboard/pmic8xxx-keypad.c |  8 +--
 drivers/input/keyboard/pxa27x_keypad.c   | 16 +++---
 drivers/input/keyboard/spear-keyboard.c  |  8 +--
 drivers/input/keyboard/st-keyscan.c      | 19 ++++---
 drivers/input/keyboard/tegra-kbc.c       | 45 +++++++--------
 17 files changed, 169 insertions(+), 262 deletions(-)
Signature · 1 line
Dmitry