replace per-quota region priorities histogram buffer with per-context one
Status from this message: [merged mm-stable] revert-mm-damon-lru_sort-adjust-local-variable-to-dynamic-allocation.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 4 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | mm/damon/core: intorduce per-context region priorities histogram bufferinclude/ mm/ | +7 | 0 replies | Applied |
| 2/4 | mm/damon/core: replace per-quota regions priority histogram buffer usage with per-context onemm/ | +6 | 0 replies | Applied |
| 3/4 | mm/damon/core: remove per-scheme region priority histogram bufferinclude/ | +0 | 0 replies | Applied |
| 4/4 | Revert "mm/damon/lru_sort: adjust local variable to dynamic allocation"mm/ | +4 | 0 replies | Applied |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] replace per-quota region priorities histogram buffer with per-context one
Each DAMOS quota (struct damos_quota) maintains a histogram for total regions size per its prioritization score. DAMOS calcultes minimum prioritization score of regions that are ok to apply the DAMOS action to while respecting the quota. The histogram is constructed only for the calculation of the minimum score in damos_adjust_quota() for each quota which called by kdamond_fn().
Hence, there is no real reason to have per-quota histogram. Only per-kdamond histogram is needed, since parallel kdamonds could have races otherwise. The current implementation is only wasting the memory, and can easily cause unintended stack usage[1].
So, introducing a per-kdamond histogram and replacing the per-quota one with it would be the right solution for the issue. However, supporting multiple DAMON contexts per kdamond is still an ongoing work[2] without a clear estimated time of arrival. Meanwhile, per-context histogram could be an effective and straightforward solution having no blocker. Let's fix the problem first in the way.
SeongJae Park (4):
mm/damon/core: intorduce per-context region priorities histogram
buffer
mm/damon/core: replace per-quota regions priority histogram buffer
usage with per-context one
mm/damon/core: remove per-scheme region priority histogram buffer Revert "mm/damon/lru_sort: adjust local variable to dynamic
allocation"
include/linux/damon.h | 3 ++- mm/damon/core.c | 14 +++++++++++--- mm/damon/lru_sort.c | 15 ++++----------- 3 files changed, 17 insertions(+), 15 deletions(-)
base-commit: 9b7ae00cf6b2d882ac7062d1cf0f752933c8e461
Signature · 1 line
2.39.2