Code cleanup and memory usage reduction
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest9 patches 4 repliesIn review
- v47 patches 0 repliesSuperseded
- v37 patches 8 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 7 patches | 8 replies | Superseded | |
| v1 | 7 patches | 11 replies | Superseded |
Changes in v5 from the cover letter
- Added patch 2 and 8
- Modified patch 9 to use the ata_dev_free_resources() function introduced in patch 8.
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | ata: libata: Cleanup libata-transportdrivers/ | +147 | 0 replies | |
| 2/9 | ata: libata-scsi: Improve ata_scsi_handle_link_detach()drivers/ | +4 | 1 reply | |
| 3/9 | ata: libata: Improve __ata_qc_complete()drivers/ | +7 | 0 replies | |
| 4/9 | ata: libata: Move sata_down_spd_limit() to libata-sata.cdrivers/ drivers/ drivers/ | +96 | 0 replies | |
| 5/9 | ata: libata: Move sata_std_hardreset() definition to libata-sata.cdrivers/ drivers/ include/ | +43 | 0 replies | |
| 6/9 | ata: libata: Rename ata_eh_read_sense_success_ncq_log()drivers/ drivers/ drivers/ +1 more | +11 | 0 replies | |
| 7/9 | ata: libata: Move sector_buf from struct ata_port to struct ata_devicedrivers/ drivers/ drivers/ +3 more | +33 | 0 replies | |
| 8/9 | ata: libata: Introduce ata_dev_free_resourcesdrivers/ drivers/ drivers/ +1 more | +24 | 1 reply | |
| 9/9 | ata: libata: Improve CDL resource managementdrivers/ drivers/ drivers/ +2 more | +56 | 2 replies |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Hannes Reinecke | Niklas Cassel |
|---|---|---|
| 1/9 | R-b | R-b |
| 2/9 | R-b | |
| 3/9 | R-b | R-b |
| 4/9 | R-b | R-b |
| 5/9 | R-b | R-b |
| 6/9 | R-b | R-b |
| 7/9 | R-b | R-b |
| 8/9 | R-b | |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/9] Code cleanup and memory usage reduction
Patch 1 of this series cleans up libata-transport (avoid forward declarations and improved kdoc comments).
Patch 2 improves device flag manipulation inata_scsi_handle_link_detach().
Patch 3 introduces a small simplification/improvement of __ata_qc_complete().
Patches 4 and 5 move code that is SATA specific from libata-core.c to libata-sata.c, without any functional change. The benefits of this code reorganization is a smaller libata binary size for hosts that do not support SATA.
Patch 6 renames some functions to make it clearer what the functions do.
Finally, patch 7 to 9 reduce memory usage of libata by:
- Moving the sector_buf buffer from struct ata_port to struct ata_device
- Agregating CDL related buffers together into a new ata_cdl structure and referencing this new structure from struct ata_device only for devices that support CDL.
Changes from V4:
- Added patch 2 and 8
- Modified patch 9 to use the ata_dev_free_resources() function introduced in patch 8.
Changes from V3:
- Small change to struct ata_cdl kzalloc() call as suggested by Niklas
- Removed bogus call to ata_dev_cleanup_cdl_resources() in patch 7
- Added review tags
Changes from V2:
- Reworked patch 1 to address Hannes' comments
- Added Hannes' review tags
Changes from V1:
- Reworked patch 1 to do more cleanups
- Added patch 6. The former patch 6 of v1 is now squashed into patch 7
- Added Niklas review tags
Damien Le Moal (9):
ata: libata: Cleanup libata-transport
ata: libata-scsi: Improve ata_scsi_handle_link_detach()
ata: libata: Improve __ata_qc_complete()
ata: libata: Move sata_down_spd_limit() to libata-sata.c
ata: libata: Move sata_std_hardreset() definition to libata-sata.c
ata: libata: Rename ata_eh_read_sense_success_ncq_log()
ata: libata: Move sector_buf from struct ata_port to struct ata_device
ata: libata: Introduce ata_dev_free_resources
ata: libata: Improve CDL resource management
drivers/ata/libata-core.c | 278 ++++++++++-------------------- drivers/ata/libata-eh.c | 13 +- drivers/ata/libata-pmp.c | 3 +- drivers/ata/libata-sata.c | 127 +++++++++++++- drivers/ata/libata-scsi.c | 11 +- drivers/ata/libata-transport.c | 299 ++++++++++++++++----------------- drivers/ata/libata-zpodd.c | 2 +- drivers/ata/libata.h | 24 ++- include/linux/libata.h | 39 +++-- 9 files changed, 419 insertions(+), 377 deletions(-)
Signature · 1 line
2.46.0