Skip to content

libxl: Implement QEMU command line probe

Anthony PERARD xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v13 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- removed commited patch
- rename "qemu_cmdline" to "qemu_opts" in struct field and func parameters.
- rename "struct libxl__qemu_available_cmd_line" to
"struct libxl__qemu_available_opts".

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2libxl: Probe QEMU for -run-with chroot=dir and use ittools/libs/light/libxl_dm.c tools/libs/light/libxl_internal.h+69 -140 replies
2/2libxl: Probe QEMU for -run-with user=user and use ittools/libs/light/libxl_dm.c tools/libs/light/libxl_internal.h+11 -20 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJason Andryuk
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [XEN PATCH v2 0/2] libxl: Implement QEMU command line probe

Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.libxl-qemu-cmdline-probe-v2

v2:
- removed commited patch
- rename "qemu_cmdline" to "qemu_opts" in struct field and func parameters.
- rename "struct libxl__qemu_available_cmd_line" to
"struct libxl__qemu_available_opts".

Starting with QEMU 9.0, the option "-chroot", that we use for the "dmrestrict" feature, is removed. We need to find out which to use between "-chroot" and "-run-with chroot=dir".

Also, "-runas" is deprecated in QEMU 9.1 and will be remove in a future release, it's replaced with "-run-with user=user".

To find out which command line option we can use, we'll spawn QEMU, and run the QMP command "query-command-line-options".

Some example of running these patches:

    with qemu-xen (8.0):
        http://logs.test-lab.xenproject.org/osstest/logs/187352/
    with QEMU (upstream, 9.1-rc3):
        http://logs.test-lab.xenproject.org/osstest/logs/187353/

Anthony PERARD (2):
libxl: Probe QEMU for -run-with chroot=dir and use it
libxl: Probe QEMU for -run-with user=user and use it

 tools/libs/light/libxl_dm.c       | 90 +++++++++++++++++++++++++------
 tools/libs/light/libxl_internal.h |  6 +++
 2 files changed, 80 insertions(+), 16 deletions(-)
Signature · 5 lines
Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech