Skip to content

Optimize wait_for_overlap

Artur Paszkiewicz linux-raid 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3md/raid5: use wait_on_bit() for R5_Overlapdrivers/md/raid5-cache.c drivers/md/raid5.c+30 -360 replies
2/3md/raid5: only add to wq if reshape is in progressdrivers/md/raid5.c+10 -30 replies
3/3md/raid5: rename wait_for_overlap to wait_for_reshapedrivers/md/raid5.c drivers/md/raid5.h+14 -140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Optimize wait_for_overlap

The wait_for_overlap wait queue is currently used in two cases, which are not really related:
- waiting for actual overlapping bios, which uses R5_Overlap bit,
- waiting for events related to reshape.

Handling every write request in raid5_make_request() involves adding to and removing from this wait queue, which uses a spinlock. With fast storage and multiple submitting threads the contention on this lock is noticeable.

This patch series aims to resolve this by separating the two cases mentioned above and using this wait queue only when reshape is in progress.

The results when testing 4k random writes on raid5 with null_blk (8 jobs, qd=64, group_thread_cnt=8):

before: 463k IOPS
after:  523k IOPS

The improvement is not huge with this series alone but it is just one of the bottlenecks. When applied onto some other changes I'm working on, it allowed to go from 845k IOPS to 975k IOPS on the same test.

Artur Paszkiewicz (3):
md/raid5: use wait_on_bit() for R5_Overlap md/raid5: only add to wait queue if reshape is in progress md/raid5: rename wait_for_overlap to wait_for_reshape

 drivers/md/raid5-cache.c |  6 +--
 drivers/md/raid5.c       | 95 +++++++++++++++++++++-------------------
 drivers/md/raid5.h       |  2 +-
 3 files changed, 52 insertions(+), 51 deletions(-)
Signature · 1 line
2.43.0