Skip to content

RFC Split up refactoring of fh_verify()

[email protected] linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6NFSD: Handle @rqstp == NULL in check_nfsd_access()fs/nfsd/export.c+24 -57 replies
2/6NFSD: Refactor nfsd_setuser_and_check_port()fs/nfsd/nfsfh.c+10 -90 replies
3/6NFSD: Avoid using rqstp->rq_vers in nfsd_set_fh_dentry()fs/nfsd/lockd.c fs/nfsd/nfsfh.c+11 -63 replies
4/6NFSD: Short-circuit fh_verify tracepoints for LOCALIOfs/nfsd/trace.h+10 -80 replies
5/6nfsd: factor out __fh_verify to allow NULL rqstp to be passedfs/nfsd/nfsfh.c+92 -760 replies
6/6nfsd: add nfsd_file_acquire_local()fs/nfsd/filecache.c fs/nfsd/filecache.h fs/nfsd/nfsfh.c +1 more+79 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/6] Split up refactoring of fh_verify()

From: Chuck Lever <[email protected]>

These six patches are meant to replace:

nfsd: factor out __fh_verify to allow NULL rqstp to be passed
nfsd: add nfsd_file_acquire_local()

I've removed the @nfs_vers parameter to __fh_verify(), and tried something a little different with the trace points. Please check my math.

These have been compile-tested, but no more than that. Interested in comments.

Chuck Lever (2):
NFSD: Avoid using rqstp->rq_vers in nfsd_set_fh_dentry()
NFSD: Short-circuit fh_verify tracepoints for LOCALIO

NeilBrown (4):
NFSD: Handle @rqstp == NULL in check_nfsd_access()
NFSD: Refactor nfsd_setuser_and_check_port()
nfsd: factor out __fh_verify to allow NULL rqstp to be passed
nfsd: add nfsd_file_acquire_local()

 fs/nfsd/export.c    |  29 ++++--
 fs/nfsd/filecache.c |  61 +++++++++++--
 fs/nfsd/filecache.h |   3 +
 fs/nfsd/lockd.c     |   6 +-
 fs/nfsd/nfsfh.c     | 210 ++++++++++++++++++++++++++------------------
 fs/nfsd/nfsfh.h     |   5 ++
 fs/nfsd/trace.h     |  18 ++--
 7 files changed, 223 insertions(+), 109 deletions(-)
Signature · 1 line
2.45.2