Skip to content

Add support for A7-A11 AIC

Nick Chan asahi linux-arm-kernel linux-devicetree lkml 4 versions – Applied

Status from this message: The following commit has been merged into the irq/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 0 repliesApplied
  2. v24 patches 5 repliesSuperseded
  3. v1 posting 2/23 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 posting 1/23 patches5 repliesSuperseded

Changes in v3 from the cover letter

- Removed mention of the IPI-always-ack code path in aic_handle_fiq(). The patch to enable A7-A10 SoC to work is a bug fix to avoid accessing sysregs on configurations that do not provide them, and the rest of the message already explains what's going on.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4dt-bindings: apple,aic: Document A7-A11 compatiblesDocumentation/devicetree/bindings/interrupt-controller/apple,aic.yaml+13 -10 replies
2/4irqchip/apple-aic: Skip unnecessary setting of use_fast_ipidrivers/irqchip/irq-apple-aic.c+1 -30 replies
3/4irqchip/apple-aic: Add a new "Global fast IPIs only" feature leveldrivers/irqchip/irq-apple-aic.c+23 -10 replies
4/4irqchip/apple-aic: Only access system registers on SoCs which provide themdrivers/irqchip/irq-apple-aic.c+12 -130 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiSven Peter
1/4A-b R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] Add support for A7-A11 AIC

Hi,

This patch series introduce support for A7-A11 SoCs into the AIC driver by if'ing out some features unavailable on them. For background information about these SoCs, see v1.

Changes since v2:
- Removed mention of the IPI-always-ack code path in aic_handle_fiq(). The patch to enable A7-A10 SoC to work is a bug fix to avoid accessing sysregs on configurations that do not provide them, and the rest of the message already explains what's going on.

Changes since v1:

- Corrected dt-binding issues pointed out by Rob, all of A7-M1 gets its own SoC compat, as well as the "apple,aic" generic fallback.

- Order the AIC dt-bindings of the SoCs by release dates instead of alphabetical
order: 's5l8960x' (A7) -> 't7000' (A8) -> 's8000' (A9) -> 't8010' (A10) -> 't8015' (A11) -> 't8103' (M1)

- The patch to disallow local fast IPI on A11 now comes before the patch that enables to AIC driver to work on slow IPI systems. This ensures all IPI-always-ack code path in aic_handle_fiq() is removed by the slow IPI patch.

- Keep local fast IPI enabled on AIC2, mistake in V1
- Describe the feature levels in the description of AIC.
- Add new patch to remove unneccessary enablement of use_fast_ipi.
- Do not try to enable use_local_fast_ipi, because it is enabled by default.

In theory M1 can also get the apple,t8015-aic (A11) compatible. However, I do not see a point in doing that.

Previous versions:
v1: https://lore.kernel.org/asahi/[email protected]
v2: https://lore.kernel.org/asahi/[email protected]

Nick Chan

Konrad Dybcio (1):
irqchip/apple-aic: Only access system registers on SoCs which provide
them

Nick Chan (3):
dt-bindings: apple,aic: Document A7-A11 compatibles irqchip/apple-aic: Skip unnecessary setting of use_fast_ipi irqchip/apple-aic: Add a new "Global fast IPIs only" feature level

 .../interrupt-controller/apple,aic.yaml       | 14 ++++-
 drivers/irqchip/irq-apple-aic.c               | 53 +++++++++++++------
 2 files changed, 49 insertions(+), 18 deletions(-)

base-commit: 985bf40edf4343dcb04c33f58b40b4a85c1776d4

Signature · 1 line
2.46.0