Skip to content

Remove falsely GT-centric design in pcode and hwmon

Matt Roper intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/xe/pcode: Treat pcode as per-tile rather than per-GTdrivers/gpu/drm/xe/compat-i915-headers/intel_pcode.h drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h drivers/gpu/drm/xe/xe_device_types.h +8 more+85 -791 reply
2/2drm/xe/hwmon: Treat hwmon as a per-device conceptdrivers/gpu/drm/xe/xe_hwmon.c+53 -421 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchLucas De Marchi
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Remove falsely GT-centric design in pcode and hwmon

Both the pcode and the hwmon code was using a GT-centric design, even though these are not GT-level concepts in the hardware. Pcode has a single instance per tile, and using a GT-centric design means that that locking isn't actually preventing all of the concurrency that it should be. hwmon is a per-device concept (all information is always read from the root tile's MMIO interface).

In both cases, these seem to be artifacts of the larger driver (mis)design where 'gt' is used as the target for MMIO operations. There's a much larger driver-wide refactor coming to address that, but let's start by fixing up these two components in preparation.

Matt Roper (2):
drm/xe/pcode: Treat pcode as per-tile rather than per-GT drm/xe/hwmon: Treat hwmon as a per-device concept

 .../drm/xe/compat-i915-headers/intel_pcode.h  |   8 +-
 .../drm/xe/compat-i915-headers/intel_uncore.h |   7 ++
 drivers/gpu/drm/xe/xe_device_types.h          |   6 +
 drivers/gpu/drm/xe/xe_gt.c                    |   2 -
 drivers/gpu/drm/xe/xe_gt_types.h              |   6 -
 drivers/gpu/drm/xe/xe_guc_pc.c                |   2 +-
 drivers/gpu/drm/xe/xe_hwmon.c                 |  95 +++++++++-------
 drivers/gpu/drm/xe/xe_pcode.c                 | 104 +++++++++---------
 drivers/gpu/drm/xe/xe_pcode.h                 |  16 +--
 drivers/gpu/drm/xe/xe_tile.c                  |   3 +
 drivers/gpu/drm/xe/xe_vram_freq.c             |   6 +-
 11 files changed, 136 insertions(+), 119 deletions(-)
Signature · 1 line
2.45.2