Skip to content

slab: add struct kmem_cache_args

Christian Brauner linux-fsdevel linux-mm 4 versions – In review

Get series with b4
b4 am [email protected] change-id 20240902-work-kmem_cache_args-e9760972c7d4

Versions newest first

  1. v4 Latest17 patches 21 repliesIn review
  2. v317 patches 0 repliesSuperseded
  3. v215 patches 51 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC6 patches1 replySuperseded

Changes in v4 from the cover letter

- Allow NULL to be passed in the struct kmem_cache_args argument of kmem_cache_create() and use default parameters in this case.
- Link to v3: https://lore.kernel.org/r/[email protected]

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17slab: s/__kmem_cache_create/do_kmem_cache_create/gmm/slab.h mm/slab_common.c mm/slub.c+4 -41 reply
2/17slab: add struct kmem_cache_argsinclude/linux/slab.h mm/slab_common.c+72 -161 reply
3/17slab: port kmem_cache_create() to struct kmem_cache_argsmm/slab_common.c+6 -21 reply
4/17slab: port kmem_cache_create_rcu() to struct kmem_cache_argsmm/slab_common.c+7 -31 reply
5/17slab: port kmem_cache_create_usercopy() to struct kmem_cache_argsmm/slab_common.c+8 -221 reply
6/17slab: pass struct kmem_cache_args to create_cache()mm/slab_common.c+19 -201 reply
7/17slab: pull kmem_cache_open() into do_kmem_cache_create()mm/slub.c+62 -701 reply
8/17slab: pass struct kmem_cache_args to do_kmem_cache_create()mm/slab.h mm/slab_common.c mm/slub.c+25 -231 reply
9/17slab: remove rcu_freeptr_offset from struct kmem_cachemm/slab.h mm/slub.c+7 -201 reply
10/17slab: port KMEM_CACHE() to struct kmem_cache_argsinclude/linux/slab.h+5 -31 reply
11/17slab: port KMEM_CACHE_USERCOPY() to struct kmem_cache_argsinclude/linux/slab.h+7 -61 reply
12/17slab: create kmem_cache_create() compatibility layerinclude/linux/slab.h mm/slab_common.c+31 -83 replies
13/17file: port to struct kmem_cache_argsfs/file_table.c+8 -31 reply
14/17slab: remove kmem_cache_create_rcu()include/linux/slab.h mm/slab_common.c+0 -461 reply
15/17slab: make kmem_cache_create_usercopy() static inlineinclude/linux/slab.h mm/slab_common.c+44 -502 replies
16/17slab: make __kmem_cache_create() static inlineinclude/linux/slab.h mm/slab_common.c+10 -412 replies
17/17io_uring: port to struct kmem_cache_argsio_uring/io_uring.c+8 -60 replies

Reviews trailers per patch

All 17 patches have a Reviewed-by or Acked-by.

PatchKees CookJens AxboeMike Rapoport (Microsoft)Vlastimil BabkaRoman Gushchin
1/17R-b R-b R-b R-b R-b
2/17R-b R-b R-b R-b R-b
3/17R-b R-b R-b R-b R-b
4/17R-b R-b R-b R-b R-b
5/17R-b R-b R-b R-b R-b
6/17R-b R-b R-b R-b R-b
7/17R-b R-b R-b R-b R-b
8/17R-b R-b R-b R-b R-b
9/17R-b R-b R-b R-b R-b
10/17R-b R-b R-b R-b R-b
11/17R-b R-b R-b R-b R-b
12/17R-b R-b R-b R-b
13/17R-b R-b R-b R-b R-b
14/17R-b R-b R-b R-b R-b
15/17R-b R-b
16/17R-b R-b
17/17R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/17] slab: add struct kmem_cache_args

Hey,

This is v4 which allows NULL to be passed in the struct kmem_cache_args argument of kmem_cache_create() and substitutes default parameters in this case.

As discussed last week the various kmem_cache_*() functions should be replaced by a unified function that is based around a struct, with only the basic parameters passed separately.

Vlastimil already said that he would like to keep core parameters out of the struct: name, object size, and flags. I personally don't care much and would not object to moving everything into the struct but that's a matter of taste and I yield that decision power to the maintainer.

In the first version I pointed out that the choice of name is somewhat forced as kmem_cache_create() is taken and the only way to reuse it would be to replace all users in one go. Or to do a global sed/kmem_cache_create()/kmem_cache_create2()/g. And then introduce kmem_cache_setup(). That doesn't strike me as a viable option.

If we really cared about the *_create() suffix then an alternative might be to do a sed/kmem_cache_setup()/kmem_cache_create()/g after every user in the kernel is ported. I honestly don't think that's worth it but I wanted to at least mention it to highlight the fact that this might lead to a naming compromise.

However, I came up with an alternative using _Generic() to create a compatibility layer that will call the correct variant of kmem_cache_create() depending on whether struct kmem_cache_args is passed or not. That compatibility layer can stay in place until we updated all calls to be based on struct kmem_cache_args.

From a cursory grep (and not excluding Documentation mentions) we will have to replace 44 kmem_cache_create_usercopy() calls and about 463 kmem_cache_create() calls which makes for a bit above 500 calls to port to kmem_cache_setup(). That'll probably be good work for people getting into kernel development.

---
Changes in v4:
- Allow NULL to be passed in the struct kmem_cache_args argument of kmem_cache_create() and use default parameters in this case.
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Reworded some commit messages.
- Picked up various RvBs.
- Added two patches to make two functions static inline.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Remove kmem_cache_setup() and add a compatibility layer built around
_Generic() so that we can keep the kmem_cache_create() name and type
switch on the third argument to either call __kmem_cache_create() or __kmem_cache_create_args().
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Christian Brauner (17):
slab: s/__kmem_cache_create/do_kmem_cache_create/g
slab: add struct kmem_cache_args
slab: port kmem_cache_create() to struct kmem_cache_args
slab: port kmem_cache_create_rcu() to struct kmem_cache_args
slab: port kmem_cache_create_usercopy() to struct kmem_cache_args
slab: pass struct kmem_cache_args to create_cache()
slab: pull kmem_cache_open() into do_kmem_cache_create()
slab: pass struct kmem_cache_args to do_kmem_cache_create()
slab: remove rcu_freeptr_offset from struct kmem_cache
slab: port KMEM_CACHE() to struct kmem_cache_args
slab: port KMEM_CACHE_USERCOPY() to struct kmem_cache_args
slab: create kmem_cache_create() compatibility layer
file: port to struct kmem_cache_args
slab: remove kmem_cache_create_rcu()
slab: make kmem_cache_create_usercopy() static inline
slab: make __kmem_cache_create() static inline
io_uring: port to struct kmem_cache_args

 fs/file_table.c      |  11 ++-
 include/linux/slab.h | 130 +++++++++++++++++++++++++++------
 io_uring/io_uring.c  |  14 ++--
 mm/slab.h            |   6 +-
 mm/slab_common.c     | 197 +++++++++++----------------------------------------
 mm/slub.c            | 162 +++++++++++++++++++++---------------------
 6 files changed, 250 insertions(+), 270 deletions(-)

---
base-commit: 6e016babce7c845ed015da25c7a097fa3482d95a
change-id: 20240902-work-kmem_cache_args-e9760972c7d4