Skip to content

perf tools: Do not set attr.exclude_guest by default (v1)

Namhyung Kim linux-perf-users lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4perf tools: Don't set attr.exclude_guest by defaulttools/perf/builtin-kvm.c tools/perf/tests/attr/test-record-dummy-C0 tools/perf/tests/parse-events.c +3 more+23 -132 replies
2/4perf tools: Simplify evsel__add_modifier()tools/perf/util/evsel.c+1 -40 replies
3/4perf stat: Add --exclude-guest optiontools/perf/Documentation/perf-stat.txt tools/perf/builtin-stat.c+9 -00 replies
4/4perf tools: Do not set exclude_guest for precise_iptools/perf/tests/parse-events.c tools/perf/util/parse-events.c+4 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC/PATCH 0/4] perf tools: Do not set attr.exclude_guest by default (v1)

Hello,

I found perf tools set exclude_guest bit inconsistently. It used to set the bit but now the default event for perf record doesn't. So I'm wondering why we want the bit in the first place.

Actually it's not good for PMUs don't support any exclusion like AMD IBS because it disables new features after the exclude_guest due to the missing feature detection logic.

AFAIK it doesn't matter for the most cases but perf kvm. If users need to set the bit, they can still use :H modifier. Please let me know if it's ok for you.

Thanks,
Namhyung

Namhyung Kim (4):
perf tools: Don't set attr.exclude_guest by default perf tools: Simplify evsel__add_modifier() perf stat: Add --exclude-guest option
perf tools: Do not set exclude_guest for precise_ip

 tools/perf/Documentation/perf-stat.txt     |  7 +++++
 tools/perf/builtin-kvm.c                   |  1 +
 tools/perf/builtin-stat.c                  |  2 ++
 tools/perf/tests/attr/test-record-dummy-C0 |  2 +-
 tools/perf/tests/parse-events.c            | 30 ++++++++++------------
 tools/perf/util/evsel.c                    |  5 +---
 tools/perf/util/parse-events.c             |  6 +----
 tools/perf/util/util.c                     | 10 ++++++--
 tools/perf/util/util.h                     |  3 +++
 9 files changed, 37 insertions(+), 29 deletions(-)
Signature · 1 line
2.46.0.469.g59c65b2a67-goog