Skip to content

Introduce DRM device wedged event

Raag Jadav amd-gfx dri-devel intel-gfx intel-xe 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest5 patches 7 repliesIn review
  2. v115 patches 0 repliesSuperseded
  3. v104 patches 21 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v94 patches15 repliesSuperseded
v84 patches6 repliesSuperseded
v75 patches27 repliesSuperseded
v64 patches7 repliesSuperseded
v54 patches15 repliesSuperseded
v43 patches10 repliesSuperseded
v33 patches6 repliesSuperseded

Patches in v12 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm: Introduce device wedged eventdrivers/gpu/drm/drm_drv.c include/drm/drm_device.h include/drm/drm_drv.h+77 -01 reply
2/5drm/doc: Document device wedged eventDocumentation/gpu/drm-uapi.rst+113 -30 replies
3/5drm/xe: Use device wedged eventdrivers/gpu/drm/xe/xe_device.c+6 -11 reply
4/5drm/i915: Use device wedged eventdrivers/gpu/drm/i915/gt/intel_reset.c+3 -02 replies
5/5drm/amdgpu: Use device wedged eventdrivers/gpu/drm/amd/amdgpu/amdgpu_device.c+4 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchAndré AlmeidaChristian KönigAravind IddamsettyShashank SharmaRodrigo ViviTvrtko Ursulin
1/5R-b R-b
2/5R-b R-b
3/5R-b A-b
4/5R-b A-b
5/5R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v12 thread

Cover letter [PATCH v12 0/5] Introduce DRM device wedged event

This series introduces device wedged event in DRM subsystem and uses it in xe, i915 and amdgpu drivers. Detailed description in commit message.

This was earlier attempted as xe specific uevent in v1 and v2 on [1]. Similar work by André Almeida on [2].
Wedged event support for amdgpu by André Almeida on [3]. Consumer implementation by Xaver Hugl on [4].

[1] https://patchwork.freedesktop.org/series/136909/
[2] https://lore.kernel.org/dri-devel/[email protected]/
[3] https://lore.kernel.org/dri-devel/[email protected]/
[4] https://invent.kde.org/plasma/kwin/-/merge_requests/7027

v2: Change authorship to Himal (Aravind)
Add uevent for all device wedged cases (Aravind)

v3: Generic implementation in DRM subsystem (Lucas)

v4: s/drm_dev_wedged/drm_dev_wedged_event
Use drm_info() (Jani)
Kernel doc adjustment (Aravind)
Change authorship to Raag (Aravind)

v5: Send recovery method with uevent (Lina)
Expose supported recovery methods via sysfs (Lucas)

v6: Access wedge_recovery_opts[] using helper function (Jani)
Use snprintf() (Jani)

v7: Convert recovery helpers into regular functions (Andy, Jani)
Aesthetic adjustments (Andy)
Handle invalid recovery method
Add documentation to drm-uapi.rst (Sima)

v8: Drop sysfs and allow sending multiple methods with uevent (Lucas, Michal)
Improve documentation (Christian, Rodrigo)
static_assert() globally (Andy)

v9: Document prerequisites section (Christian)
Provide 'none' method for device reset (Christian) Provide recovery opts using switch cases

v10: Clarify mmap cleanup and consumer prerequisites (Christian, Aravind)

v11: Log device reset (André)
Reference wedged event in device reset chapter (André) Wedged event support for amdgpu (André)

v12: Refine consumer expectations and terminologies (Xaver, Pekka)

André Almeida (1):
drm/amdgpu: Use device wedged event

Raag Jadav (4):
drm: Introduce device wedged event
drm/doc: Document device wedged event
drm/xe: Use device wedged event
drm/i915: Use device wedged event

 Documentation/gpu/drm-uapi.rst             | 116 ++++++++++++++++++++-
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |   4 +
 drivers/gpu/drm/drm_drv.c                  |  68 ++++++++++++
 drivers/gpu/drm/i915/gt/intel_reset.c      |   3 +
 drivers/gpu/drm/xe/xe_device.c             |   7 +-
 include/drm/drm_device.h                   |   8 ++
 include/drm/drm_drv.h                      |   1 +
 7 files changed, 203 insertions(+), 4 deletions(-)
Signature · 1 line
2.34.1