btrfs: Don't block system suspend during fstrim
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest2 patches 9 repliesIn review
- v52 patches 3 repliesSuperseded
- v43 patches 4 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 3 patches | 6 replies | Superseded | |
| v1 | 1 patch | 1 reply | Superseded |
Changes in v6 from the cover letter
* Make chunk size a define
* Remove superfluous trim_interrupted checks after moving them to trim_no_bitmap/trim_bitmaps
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | btrfs: Split remaining space to discard in chunksfs/ fs/ | +16 | 0 replies | |
| 2/2 | btrfs: Don't block system suspend during fstrimfs/ fs/ fs/ | +14 | 5 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Qu Wenruo |
|---|---|
| Series | R-b |
| 1/2 | |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/2] btrfs: Don't block system suspend during fstrim
Changes since v5:
* Make chunk size a define
* Remove superfluous trim_interrupted checks after moving them to trim_no_bitmap/trim_bitmaps
Changes since v4:
* Set chunk size to 1G
* Set proper error return codes in case of interruption
* Dropped fstrim_range fixup as pulled in -next
Changes since v3:
* Went back to manual chunk size
Changes since v2:
* Use blk_alloc_discard_bio directly
* Reset ret to ERESTARTSYS
Changes since v1:
* Use bio_discard_limit to calculate chunk size
* Makes use of the split chunks
Original discussion: https://lore.kernel.org/lkml/[email protected]/
v1: https://lore.kernel.org/lkml/[email protected]/
v2: https://lore.kernel.org/lkml/[email protected]/
v3: https://lore.kernel.org/lkml/[email protected]/
v4: https://lore.kernel.org/lkml/[email protected]/
v5: https://lore.kernel.org/lkml/[email protected]/
---
NB: I didn't change btrfs_discard_workfn yet to add error checks as I don't know what semantics we should have in that case. The work queue is always re-scheduled and created with WQ_FREEZABLE so it should be automatically frozen. Shall I simply add some logs?
---
Luca Stefani (2):
btrfs: Split remaining space to discard in chunks
btrfs: Don't block system suspend during fstrim
fs/btrfs/extent-tree.c | 26 +++++++++++++++++++++----- fs/btrfs/free-space-cache.c | 4 ++-- fs/btrfs/free-space-cache.h | 6 ++++++ fs/btrfs/volumes.h | 1 + 4 files changed, 30 insertions(+), 7 deletions(-)
Signature · 1 line
2.46.0