Skip to content

drm/i915: Use DSB for plane/color management commits

Ville Syrjala intel-gfx intel-xe 2 versions – Applied

Status from this message: Pushed to drm-intel-next. Thanks for the reviews.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 1 replyApplied
  2. v113 patches 1 replySuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/13drm/i915/dsb: Avoid reads of the DSB buffer for indexed register writesdrivers/gpu/drm/i915/display/intel_dsb.c+32 -220 replies
2/13drm/i915: Prepare clear color before wait_for_dependencies()drivers/gpu/drm/i915/display/intel_display.c+2 -20 replies
3/13drm/i915/dsb: Generate the DSB buffer in commit_tail()drivers/gpu/drm/i915/display/intel_display.c+10 -130 replies
4/13drm/i915/dsb: Enable programmable DSB interruptdrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dsb.c drivers/gpu/drm/i915/display/intel_dsb.h+30 -20 replies
5/13drm/i915/dsb: Introduce intel_dsb_vblank_evade()drivers/gpu/drm/i915/display/intel_dsb.c drivers/gpu/drm/i915/display/intel_dsb.h+33 -00 replies
6/13drm/i915/dsb: Introduce intel_dsb_wait_usec()drivers/gpu/drm/i915/display/intel_dsb.c drivers/gpu/drm/i915/display/intel_dsb.h+7 -00 replies
7/13drm/i915/dsb: Introduce intel_dsb_wait_vblanks()drivers/gpu/drm/i915/display/intel_dsb.c drivers/gpu/drm/i915/display/intel_dsb.h+7 -00 replies
8/13drm/i915: Introduce intel_scanlines_to_usecs()drivers/gpu/drm/i915/display/intel_crtc.c drivers/gpu/drm/i915/display/intel_crtc.h+13 -00 replies
9/13drm/i915/dsb: Introduce intel_dsb_wait_vblank_delay()drivers/gpu/drm/i915/display/intel_dsb.c drivers/gpu/drm/i915/display/intel_dsb.h+13 -00 replies
10/13drm/i915: Extract intel_crtc_prepare_vblank_event()drivers/gpu/drm/i915/display/intel_crtc.c drivers/gpu/drm/i915/display/intel_crtc.h+18 -60 replies
11/13drm/i915: Plumb 'dsb' all way to the plane hooksdrivers/gpu/drm/i915/display/i9xx_plane.c drivers/gpu/drm/i915/display/intel_atomic_plane.c drivers/gpu/drm/i915/display/intel_atomic_plane.h +8 more+333 -2460 replies
12/13drm/i915: Plumb 'dsb' all way to the color commit hooksdrivers/gpu/drm/i915/display/intel_color.c drivers/gpu/drm/i915/display/intel_color.h drivers/gpu/drm/i915/display/intel_display.c +1 more+111 -840 replies
13/13drm/i915/dsb: Use DSB for plane/color management updatesdrivers/gpu/drm/i915/display/intel_atomic.c drivers/gpu/drm/i915/display/intel_color.c drivers/gpu/drm/i915/display/intel_crtc.c +2 more+128 -400 replies

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchAnimesh Manna
1/13R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13R-b
9/13R-b
10/13R-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/13] drm/i915: Use DSB for plane/color management commits

From: Ville Syrjälä <[email protected]>

Use the DSB to perform simple plane/color management commits. Anything more complicatd (modesets and fastsets) are still punted to the mmio path.

Also DSB won't be used when any of these are in use:
- scalers (scaler code needs more work)
- VRR (need to figure out a race free commit completion scheme)
- PSR (zero thoughts given for PSR interactions so far)
- async flips (no real though given here either)

v2: rebase

Ville Syrjälä (13):
drm/i915/dsb: Avoid reads of the DSB buffer for indexed register
writes
drm/i915: Prepare clear color before wait_for_dependencies() drm/i915/dsb: Generate the DSB buffer in commit_tail() drm/i915/dsb: Enable programmable DSB interrupt drm/i915/dsb: Introduce intel_dsb_vblank_evade() drm/i915/dsb: Introduce intel_dsb_wait_usec() drm/i915/dsb: Introduce intel_dsb_wait_vblanks() drm/i915: Introduce intel_scanlines_to_usecs() drm/i915/dsb: Introduce intel_dsb_wait_vblank_delay() drm/i915: Extract intel_crtc_prepare_vblank_event() drm/i915: Plumb 'dsb' all way to the plane hooks drm/i915: Plumb 'dsb' all way to the color commit hooks drm/i915/dsb: Use DSB for plane/color management updates

 drivers/gpu/drm/i915/display/i9xx_plane.c     |  22 +-
 drivers/gpu/drm/i915/display/intel_atomic.c   |   5 +-
 .../gpu/drm/i915/display/intel_atomic_plane.c |  49 +--
 .../gpu/drm/i915/display/intel_atomic_plane.h |  19 +-
 drivers/gpu/drm/i915/display/intel_color.c    | 207 ++++++------
 drivers/gpu/drm/i915/display/intel_color.h    |   7 +-
 drivers/gpu/drm/i915/display/intel_crtc.c     |  37 ++-
 drivers/gpu/drm/i915/display/intel_crtc.h     |   5 +
 drivers/gpu/drm/i915/display/intel_cursor.c   | 101 +++---
 drivers/gpu/drm/i915/display/intel_de.h       |  11 +
 drivers/gpu/drm/i915/display/intel_display.c  | 180 ++++++++---
 .../drm/i915/display/intel_display_types.h    |  23 +-
 drivers/gpu/drm/i915/display/intel_dsb.c      | 137 ++++++--
 drivers/gpu/drm/i915/display/intel_dsb.h      |   7 +
 .../drm/i915/display/intel_modeset_setup.c    |   4 +-
 drivers/gpu/drm/i915/display/intel_sprite.c   |  27 +-
 .../drm/i915/display/skl_universal_plane.c    | 305 ++++++++++--------
 drivers/gpu/drm/xe/display/xe_plane_initial.c |   2 +-
 18 files changed, 735 insertions(+), 413 deletions(-)
Signature · 1 line
2.45.2