Skip to content

perf tools: Constify BPF control data properly (v1)

Namhyung Kim bpf linux-perf-users lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5perf stat: Constify control data for BPFtools/perf/util/bpf_counter_cgroup.c tools/perf/util/bpf_skel/bperf_cgroup.bpf.c+4 -40 replies
2/5perf ftrace latency: Constify control data for BPFtools/perf/util/bpf_ftrace.c tools/perf/util/bpf_skel/func_latency.bpf.c+8 -70 replies
3/5perf kwork: Constify control data for BPFtools/perf/util/bpf_kwork.c tools/perf/util/bpf_kwork_top.c tools/perf/util/bpf_skel/kwork_top.bpf.c +1 more+13 -100 replies
4/5perf lock contention: Constify control data for BPFtools/perf/util/bpf_lock_contention.c tools/perf/util/bpf_skel/lock_contention.bpf.c+38 -340 replies
5/5perf record offcpu: Constify control data for BPFtools/perf/util/bpf_off_cpu.c tools/perf/util/bpf_skel/off_cpu.bpf.c+13 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCHSET 0/5] perf tools: Constify BPF control data properly (v1)

Hello,

I've realized that some control data (usually for filter actions) should be defined as 'const volatile' so that it can passed to the BPF core and to be optimized properly (like with dead code elimination).

Convert the existing codes with the similar patterns.

Thanks,
Namhyung

Namhyung Kim (5):
perf stat: Constify control data for BPF perf ftrace latency: Constify control data for BPF perf kwork: Constify control data for BPF perf lock contention: Constify control data for BPF perf record offcpu: Constify control data for BPF

 tools/perf/util/bpf_counter_cgroup.c          |  6 +--
 tools/perf/util/bpf_ftrace.c                  |  8 ++--
 tools/perf/util/bpf_kwork.c                   |  9 ++--
 tools/perf/util/bpf_kwork_top.c               |  7 +--
 tools/perf/util/bpf_lock_contention.c         | 45 ++++++++++---------
 tools/perf/util/bpf_off_cpu.c                 | 16 +++----
 tools/perf/util/bpf_skel/bperf_cgroup.bpf.c   |  2 +-
 tools/perf/util/bpf_skel/func_latency.bpf.c   |  7 +--
 tools/perf/util/bpf_skel/kwork_top.bpf.c      |  2 +-
 tools/perf/util/bpf_skel/kwork_trace.bpf.c    |  5 ++-
 .../perf/util/bpf_skel/lock_contention.bpf.c  | 27 +++++------
 tools/perf/util/bpf_skel/off_cpu.bpf.c        |  9 ++--
 12 files changed, 76 insertions(+), 67 deletions(-)
Signature · 1 line
2.46.0.469.g59c65b2a67-goog