perf tools: Do not set attr.exclude_guest by default (v2)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | perf tools: Don't set attr.exclude_guest by defaulttools/ tools/ tools/ +3 more | +23 | 2 replies | |
| 2/8 | perf tools: Simplify evsel__add_modifier()tools/ tools/ tools/ | +3 | 0 replies | |
| 3/8 | perf stat: Add --exclude-guest optiontools/ tools/ | +9 | 0 replies | |
| 4/8 | perf tools: Do not set exclude_guest for precise_iptools/ tools/ | +4 | 0 replies | |
| 5/8 | perf tools: Detect missing kernel features properlytools/ tools/ | +249 | 0 replies | |
| 6/8 | perf tools: Separate exclude_hv fallbacktools/ | +9 | 0 replies | |
| 7/8 | perf tools: Add fallback for exclude_guesttools/ | +21 | 4 replies | |
| 8/8 | perf tools: Check fallback error and ordertools/ | +4 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC/PATCHSET 0/8] perf tools: Do not set attr.exclude_guest by default (v2)
Hello,
I found perf tools set exclude_guest bit inconsistently. It used to set the bit but now the default event for perf record doesn't. So I'm wondering why we want the bit in the first place.
Actually it's not good for PMUs don't support any exclusion like AMD IBS because it disables new features after the exclude_guest due to the missing feature detection logic.
v2 changes)
* update the missing feature detection logic
* separate exclude_hv fallback
* add new fallback for exclude_guest
v1) https://lore.kernel.org/lkml/[email protected]/
AFAIK it doesn't matter for the most cases but perf kvm. If users need to set the bit, they can still use :H modifier. For vPMU pass- through or Apple M1, it'd add the exclude_guest during the fallback logic. Please let me know if it's ok for you.
The code is available at 'perf/exclude-v2' branch ingit://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Thanks,
Namhyung
Namhyung Kim (8):
perf tools: Don't set attr.exclude_guest by default perf tools: Simplify evsel__add_modifier() perf stat: Add --exclude-guest option
perf tools: Do not set exclude_guest for precise_ip perf tools: Detect missing kernel features properly perf tools: Separate exclude_hv fallback perf tools: Add fallback for exclude_guest perf tools: Check fallback error and order
tools/perf/Documentation/perf-stat.txt | 7 + tools/perf/builtin-kvm.c | 1 + tools/perf/builtin-stat.c | 2 + tools/perf/dlfilters/dlfilter-test-api-v0.c | 2 +- tools/perf/dlfilters/dlfilter-test-api-v2.c | 2 +- tools/perf/tests/attr/test-record-dummy-C0 | 2 +- tools/perf/tests/parse-events.c | 30 +- tools/perf/util/evsel.c | 393 ++++++++++++++------ tools/perf/util/evsel.h | 1 - tools/perf/util/parse-events.c | 6 +- tools/perf/util/util.c | 10 +- tools/perf/util/util.h | 3 + 12 files changed, 322 insertions(+), 137 deletions(-)
Signature · 1 line
2.46.0.469.g59c65b2a67-goog