Skip to content

Add BIP for AVRCP covert art OBEX client

Frédéric Danis linux-bluetooth 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 1 replyIn review
  2. v39 patches 3 repliesSuperseded
  3. v27 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v17 patches4 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5obexd: Add BIP client for AVRCP cover art downloadMakefile.obexd doc/org.bluez.obex.Client.rst obexd/client/bip.c +2 more+187 -01 reply
2/5obexd: Add Properties to org.bluez.obex.ImageMakefile.obexd obexd/client/bip-common.c obexd/client/bip-common.h +1 more+902 -00 replies
3/5obexd: Add Get to org.bluez.obex.Imageobexd/client/bip-common.c obexd/client/bip-common.h obexd/client/bip.c+193 -10 replies
4/5avrcp: Update controller SDP record with cover art supportprofiles/audio/avrcp.c+7 -50 replies
5/5doc: Add description of org.bluez.obex.ImageMakefile.am doc/org.bluez.obex.Image.rst+124 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH BlueZ v4 0/5] Add BIP for AVRCP covert art OBEX client

If AVRCP Target supports Cover Art download its SDP record contains an additional access protocol for OBEX with an LCAP PSM on which the OBEX client session should connect to, with the specific OBEX target header 7163DD54-4A7E-11E2-B47C-0050C2490048.

Once the OBEX session is connected, the AVRCP track metadata will contain an Image Handle which can be used to get the associated image using GetImageThumbnail or GetImage with one of the description property found with GetImageProperties.

This has been tested with iPhone 14, iPhone 15 Pro and Samsung S23.

v1 -> v2: Parse integer properties as integer instead of string

          Return GetImageProperties values as aa{sv} instead of aa{ss}
          Get properties for GetImage as a{sv} instead of a{ss}
          Set new properties and interface as experimental

v2 -> v3: Rename obexd/client/bip-avrcp.[ch] to obexd/client/bip.[ch]
Update the AVRCP Controller version in SDP to 1.6 Add commit to support for specific headers in obex transfer Fix memory leaks
v3 -> v4: Commits 1-4 has been merged
Change org.bluez.obex.BipAvrcp1 to org.bluez.obex.Image1 Change GetImageThumbnail to GetThumbnail
Change GetImageProperties to Properties
Change GetImage to Get
Add possible property values for the description dicts

Frédéric Danis (5):
obexd: Add BIP client for AVRCP cover art download
obexd: Add Properties to org.bluez.obex.Image
obexd: Add Get to org.bluez.obex.Image
avrcp: Update controller SDP record with cover art support
doc: Add description of org.bluez.obex.Image

 Makefile.am                   |   9 +-
 Makefile.obexd                |   2 +
 doc/org.bluez.obex.Client.rst |   1 +
 doc/org.bluez.obex.Image.rst  | 118 +++++
 obexd/client/bip-common.c     | 800 ++++++++++++++++++++++++++++++++++
 obexd/client/bip-common.h     |  24 +
 obexd/client/bip.c            | 440 +++++++++++++++++++
 obexd/client/bip.h            |  12 +
 obexd/client/manager.c        |   2 +
 profiles/audio/avrcp.c        |  12 +-
 10 files changed, 1412 insertions(+), 8 deletions(-)
 create mode 100644 doc/org.bluez.obex.Image.rst
 create mode 100644 obexd/client/bip-common.c
 create mode 100644 obexd/client/bip-common.h
 create mode 100644 obexd/client/bip.c
 create mode 100644 obexd/client/bip.h
Signature · 1 line
2.34.1