Skip to content

Backport "make svc_stat per-net instead of global"

[email protected] linux-nfs stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19nfsd: move reply cache initialization into nfsd startupfs/nfsd/nfsctl.c fs/nfsd/nfssvc.c+9 -91 reply
2/19nfsd: move init of percpu reply_cache_stats counters back to nfsd_init_netfs/nfsd/cache.h fs/nfsd/nfscache.c fs/nfsd/nfsctl.c+25 -120 replies
3/19NFSD: Refactor nfsd_reply_cache_free_locked()fs/nfsd/nfscache.c+21 -80 replies
4/19NFSD: Rename nfsd_reply_cache_alloc()fs/nfsd/nfscache.c+3 -30 replies
5/19NFSD: Replace nfsd_prune_bucket()fs/nfsd/nfscache.c fs/nfsd/trace.h+85 -150 replies
6/19NFSD: Refactor the duplicate reply cache shrinkerfs/nfsd/nfscache.c+41 -450 replies
7/19NFSD: simplify error paths in nfsd_svc()fs/nfsd/nfssvc.c+4 -100 replies
8/19NFSD: Rewrite synopsis of nfsd_percpu_counters_init()fs/nfsd/stats.c fs/nfsd/stats.h+4 -40 replies
9/19NFSD: Fix frame size warning in svc_export_parse()fs/nfsd/export.c fs/nfsd/export.h fs/nfsd/stats.h+31 -170 replies
10/19sunrpc: don't change ->sv_stats if it doesn't existnet/sunrpc/svc.c+16 -80 replies
11/19nfsd: stop setting ->pg_stats for unused statsfs/lockd/svc.c fs/nfs/callback.c fs/nfsd/nfssvc.c+0 -110 replies
12/19sunrpc: pass in the sv_stats struct through svc_create_pooledfs/nfsd/nfssvc.c include/linux/sunrpc/svc.h net/sunrpc/svc.c+12 -70 replies
13/19sunrpc: remove ->pg_stats from svc_programfs/nfsd/nfssvc.c include/linux/sunrpc/svc.h+0 -20 replies
14/19sunrpc: use the struct net as the svc proc privatenet/sunrpc/stats.c+1 -10 replies
15/19nfsd: rename NFSD_NET_* to NFSD_STATS_*fs/nfsd/netns.h fs/nfsd/nfscache.c fs/nfsd/stats.h+7 -70 replies
16/19nfsd: expose /proc/net/sunrpc/nfsd in net namespacesfs/nfsd/nfsctl.c fs/nfsd/stats.c fs/nfsd/stats.h+15 -200 replies
17/19nfsd: make all of the nfsd stats per-network namespacefs/nfsd/cache.h fs/nfsd/netns.h fs/nfsd/nfs4proc.c +6 more+64 -910 replies
18/19nfsd: remove nfsd_stats, make th_cnt a global counterfs/nfsd/nfsd.h fs/nfsd/nfssvc.c fs/nfsd/stats.c +1 more+5 -100 replies
19/19nfsd: make svc_stat per-network namespace instead of globalfs/nfsd/netns.h fs/nfsd/nfsctl.c fs/nfsd/nfssvc.c +2 more+11 -90 replies

Reviews trailers per patch

17 of 19 patches have a Reviewed-by or Acked-by.

PatchEirik FullerJeff Layton
1/19
2/19Reported-and-tested-by
3/19R-b
4/19R-b
5/19R-b
6/19R-b
7/19R-b
8/19R-b
9/19R-b
10/19R-b
11/19R-b
12/19R-b
13/19R-b
14/19R-b
15/19R-b
16/19R-b
17/19R-b
18/19R-b
19/19R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 5.10.y 00/19] Backport "make svc_stat per-net instead of global"

From: Chuck Lever <[email protected]>

Following up on

https://lore.kernel.org/linux-nfs/[email protected]/

Here is a backport series targeting origin/linux-5.10.y that closes the information leak described in the above thread.

Review comments welcome.

Chuck Lever (6):
NFSD: Refactor nfsd_reply_cache_free_locked()
NFSD: Rename nfsd_reply_cache_alloc()
NFSD: Replace nfsd_prune_bucket()
NFSD: Refactor the duplicate reply cache shrinker
NFSD: Rewrite synopsis of nfsd_percpu_counters_init()
NFSD: Fix frame size warning in svc_export_parse()

Jeff Layton (2):
nfsd: move reply cache initialization into nfsd startup
nfsd: move init of percpu reply_cache_stats counters back to
nfsd_init_net

Josef Bacik (10):
sunrpc: don't change ->sv_stats if it doesn't exist
nfsd: stop setting ->pg_stats for unused stats
sunrpc: pass in the sv_stats struct through svc_create_pooled
sunrpc: remove ->pg_stats from svc_program
sunrpc: use the struct net as the svc proc private
nfsd: rename NFSD_NET_* to NFSD_STATS_*
nfsd: expose /proc/net/sunrpc/nfsd in net namespaces
nfsd: make all of the nfsd stats per-network namespace
nfsd: remove nfsd_stats, make th_cnt a global counter
nfsd: make svc_stat per-network namespace instead of global

NeilBrown (1):
NFSD: simplify error paths in nfsd_svc()

 fs/lockd/svc.c             |   3 -
 fs/nfs/callback.c          |   3 -
 fs/nfsd/export.c           |  32 ++++--
 fs/nfsd/export.h           |   4 +-
 fs/nfsd/netns.h            |  25 ++++-
 fs/nfsd/nfs4proc.c         |   6 +-
 fs/nfsd/nfscache.c         | 202 ++++++++++++++++++++++---------------
 fs/nfsd/nfsctl.c           |  24 ++---
 fs/nfsd/nfsd.h             |   1 +
 fs/nfsd/nfsfh.c            |   3 +-
 fs/nfsd/nfssvc.c           |  38 ++++---
 fs/nfsd/stats.c            |  52 ++++------
 fs/nfsd/stats.h            |  83 ++++++---------
 fs/nfsd/trace.h            |  22 ++++
 fs/nfsd/vfs.c              |   6 +-
 include/linux/sunrpc/svc.h |   5 +-
 net/sunrpc/stats.c         |   2 +-
 net/sunrpc/svc.c           |  36 ++++---
 18 files changed, 306 insertions(+), 241 deletions(-)
Signature · 1 line
2.45.1