perf tools: Do not set attr.exclude_guest by default (v3)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest10 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | perf tools: Add fallback for exclude_guesttools/ tools/ | +22 | 2 replies | |
| 2/10 | perf tools: Don't set attr.exclude_guest by defaulttools/ tools/ tools/ +3 more | +23 | 1 reply | |
| 3/10 | perf tools: Simplify evsel__add_modifier()tools/ tools/ tools/ | +3 | 0 replies | |
| 4/10 | perf stat: Add --exclude-guest optiontools/ tools/ | +9 | 7 replies | |
| 5/10 | perf tools: Do not set exclude_guest for precise_iptools/ tools/ | +4 | 0 replies | |
| 6/10 | perf tools: Detect missing kernel features properlytools/ tools/ | +249 | 0 replies | |
| 7/10 | perf tools: Separate exclude_hv fallbacktools/ | +13 | 2 replies | |
| 8/10 | perf tools: Move x86__is_amd_cpu() to util/env.ctools/ tools/ tools/ +3 more | +28 | 0 replies | |
| 9/10 | perf tools: Check fallback error and ordertools/ | +21 | 0 replies | |
| 10/10 | perf record: Just use "cycles:P" as the default eventtools/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC/PATCHSET 00/10] perf tools: Do not set attr.exclude_guest by default (v3)
Hello,
I found perf tools set exclude_guest bit inconsistently. It used to set the bit but now the default event for perf record doesn't. So I'm wondering why we want the bit in the first place.
Actually it's not good for PMUs don't support any exclusion like AMD IBS because it disables new features after the exclude_guest due to the missing feature detection logic.
v3 changes)
* move exclude_guest fallback to the front
* fix precise_max handling on AMD
* simplify the default event for perf record
v2) https://lore.kernel.org/lkml/[email protected]/
* update the missing feature detection logic
* separate exclude_hv fallback
* add new fallback for exclude_guest
v1) https://lore.kernel.org/lkml/[email protected]/
AFAIK it doesn't matter for the most cases but perf kvm. If users need to set the bit, they can still use :H modifier. For vPMU pass- through or Apple M1, it'd add the exclude_guest during the fallback logic.
Also the kernel feature detection logic should be separated from the exclude bit tests since it depends on the PMU implementation rather than the core kernel features. So I changed it to use a software event for the detection and factor out some hw-specific checks.
The code is available at 'perf/exclude-v3' branch ingit://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Thanks,
Namhyung
Namhyung Kim (10):
perf tools: Add fallback for exclude_guest perf tools: Don't set attr.exclude_guest by default perf tools: Simplify evsel__add_modifier() perf stat: Add --exclude-guest option
perf tools: Do not set exclude_guest for precise_ip perf tools: Detect missing kernel features properly perf tools: Separate exclude_hv fallback perf tools: Move x86__is_amd_cpu() to util/env.c perf tools: Check fallback error and order perf record: Just use "cycles:P" as the default event
tools/perf/Documentation/perf-stat.txt | 7 + tools/perf/arch/x86/util/Build | 1 - tools/perf/arch/x86/util/env.c | 19 - tools/perf/arch/x86/util/env.h | 7 - tools/perf/arch/x86/util/pmu.c | 2 +- tools/perf/builtin-kvm.c | 1 + tools/perf/builtin-record.c | 4 +- tools/perf/builtin-stat.c | 5 +- tools/perf/dlfilters/dlfilter-test-api-v0.c | 2 +- tools/perf/dlfilters/dlfilter-test-api-v2.c | 2 +- tools/perf/tests/attr/test-record-dummy-C0 | 2 +- tools/perf/tests/parse-events.c | 30 +- tools/perf/util/env.c | 23 ++ tools/perf/util/env.h | 4 + tools/perf/util/evsel.c | 410 +++++++++++++++----- tools/perf/util/evsel.h | 1 - tools/perf/util/parse-events.c | 6 +- tools/perf/util/util.c | 10 +- tools/perf/util/util.h | 3 + 19 files changed, 371 insertions(+), 168 deletions(-) delete mode 100644 tools/perf/arch/x86/util/env.c delete mode 100644 tools/perf/arch/x86/util/env.h
Signature · 1 line
2.46.0.469.g59c65b2a67-goog