Skip to content

RFC Prep perf trace for a generic BPF+BTF pretty printer

Arnaldo Carvalho de Melo linux-perf-users lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2perf trace augmented_syscalls.bpf: Move the renameat augmenter to renameat2, temporarilytools/perf/util/bpf_skel/augmented_raw_syscalls.bpf.c+2 -22 replies
2/2perf trace: Use a common encoding for augmented arguments, with size + error + payloadtools/perf/trace/beauty/perf_event_open.c tools/perf/trace/beauty/sockaddr.c tools/perf/trace/beauty/timespec.c +1 more+66 -441 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchIan Rogers
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RFC 0/2] Prep perf trace for a generic BPF+BTF pretty printer

From: Arnaldo Carvalho de Melo <[email protected]>

Hi,

This is an attempt at paving the way for the remaining parts of
Howard's work on this years GSoC to be merged, as we want to keep the existing pretty printers for the few structs we have, that have special characteristics (see the commit logs) while having the generic BPF + BTF collector/pretty printer, using the libbpf BPF dumper (see more ideas on the commit log on how to improve it, maybe even getting tools/perf/trace/beauty/ into tools/lib/beauty/ to get reused by libbpf).

I plan to work on the weekend to plugging his latest series on
top of these patches so that we can get it merged in the next merge window.

Any comment/test is more than welcome,

- Arnaldo

Arnaldo Carvalho de Melo (2):
perf trace augmented_syscalls.bpf: Move the renameat augmenter to
renameat2, temporarily
perf trace: Use a common encoding for augmented arguments, with size +
error + payload

 tools/perf/trace/beauty/perf_event_open.c     |   2 +-
 tools/perf/trace/beauty/sockaddr.c            |   2 +-
 tools/perf/trace/beauty/timespec.c            |   2 +-
 .../bpf_skel/augmented_raw_syscalls.bpf.c     | 108 +++++++++++-------
 4 files changed, 68 insertions(+), 46 deletions(-)
Signature · 1 line
2.46.0