Skip to content

Fix sum_trb_lengths()

Michal Pecio linux-usb 1 version In review

Get series with b4
b4 am 20240910160114.50b77a91@foxbook

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2usb: xhci: Remove unused parameters of next_trb()drivers/usb/host/xhci-ring.c+7 -90 replies
2/2usb: xhci: Fix sum_trb_lengths()drivers/usb/host/xhci-ring.c+7 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Fix sum_trb_lengths()

Hi,

This function sums from ring->dequeue instead of td->first_trb, and this is even documented. Makes no sense and doesn't work right.

I searched xhci-ring.c and this appears to be the last such abuse of 'dequeue' still surviving to this day.

Regards,
Michal